Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -308,9 +308,9 @@ private void closeAfterFailure(Throwable failure, Runnable closeConnection) {

/**
* Logs a failure without letting the logging itself end this thread: building the message and
* rendering the throwable both allocate, which under memory pressure can raise another error, so
* everything that allocates stays inside the guard. ThreadDeath and other virtual machine errors
* are still allowed through.
* rendering the throwable both allocate, which under memory pressure can raise another error,
* so everything that allocates stays inside the guard. ThreadDeath and other virtual machine
* errors are still allowed through.
*/
private void logFailure(String message, Throwable failure) {
try {
Expand Down
2 changes: 1 addition & 1 deletion lib/php/lib/Transport/TTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public function decrementRecursionDepth(): void
public function checkStringSize(int $len): void
{
$max = TProtocol::DEFAULT_MAX_STRING_SIZE;
if ($max > 0 && $len > $max) {
Comment thread
kpumuk marked this conversation as resolved.
if ($len > $max) {
throw new TProtocolException(
"String size ($len) larger than the maximum ($max)",
TProtocolException::SIZE_LIMIT
Expand Down
Loading