Skip to content

Fix PHPStan and Java Spotless failures - #4032

Merged
kpumuk merged 1 commit into
apache:masterfrom
kpumuk:sca-build-fixes
Oct 21, 2026
Merged

kpumuk merged 1 commit into
apache:masterfrom
kpumuk:sca-build-fixes

Conversation

@kpumuk

@kpumuk kpumuk commented Oct 20, 2026

Copy link
Copy Markdown
Member

Restore the PHP static-analysis and Java formatting checks that currently fail on master and affect otherwise unrelated pull requests.

The PHPStan job fails with:

Comparison operation ">" between 16384000 and 0 is always true.

The default string-size limit is a fixed, positive constant. Remove the redundant comparison without changing which sizes are rejected.

The Java Spotless job fails with:

Execution failed for task ':spotlessJavaCheck'.
> The following files had format violations:
      src/main/java/org/apache/thrift/server/TSaslNonblockingServer.java

Reflow the affected Javadoc to match Spotless; no Java runtime code changes.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Client: java,php

Co-Authored-By: OpenAI Codex (gpt-6.1-sol) <codex@openai.com>
Copilot AI balanced review requested due to automatic review settings October 20, 2026 22:50
@mergeable mergeable Bot added java Pull requests that update Java code php labels Oct 20, 2026
Comment thread lib/php/lib/Transport/TTransport.php

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

No open issues 🎉

What changed in this PR

Restores CI green by addressing a PHPStan false-positive/guaranteed-true condition and fixing a Java Spotless Javadoc formatting violation.

Changes:

  • Simplify PHP string-size limit check to remove a redundant comparison that PHPStan flags.
  • Reflow Javadoc in TSaslNonblockingServer to satisfy Spotless formatting rules.
File Description
lib/​php/​lib/​Transport/​TTransport.php Removes redundant $max > 0 guard in checkStringSize() to satisfy PHPStan.
lib/​java/​src/​main/​java/​org/​apache/​thrift/​server/​TSaslNonblockingServer.java Wraps Javadoc lines to match Spotless formatting requirements.

Review effort: Lite

@kpumuk
kpumuk merged commit f47092e into apache:master Oct 21, 2026
108 of 109 checks passed
@kpumuk
kpumuk deleted the sca-build-fixes branch October 21, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code php

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants