Repository navigation
Fix PHPStan and Java Spotless failures - #4032
Merged
Merged
Conversation
Client: java,php Co-Authored-By: OpenAI Codex (gpt-6.1-sol) <codex@openai.com>
fishy
approved these changes
Oct 20, 2026
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
What changed in this PR
Restores CI green by addressing a PHPStan false-positive/guaranteed-true condition and fixing a Java Spotless Javadoc formatting violation.
Changes:
- Simplify PHP string-size limit check to remove a redundant comparison that PHPStan flags.
- Reflow Javadoc in
TSaslNonblockingServerto satisfy Spotless formatting rules.
| File | Description |
|---|---|
| lib/php/lib/Transport/TTransport.php | Removes redundant $max > 0 guard in checkStringSize() to satisfy PHPStan. |
| lib/java/src/main/java/org/apache/thrift/server/TSaslNonblockingServer.java | Wraps Javadoc lines to match Spotless formatting requirements. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the PHP static-analysis and Java formatting checks that currently fail on master and affect otherwise unrelated pull requests.
The PHPStan job fails with:
The default string-size limit is a fixed, positive constant. Remove the redundant comparison without changing which sizes are rejected.
The Java Spotless job fails with:
Reflow the affected Javadoc to match Spotless; no Java runtime code changes.
[skip ci]anywhere in the commit message to free up build resources.