Repository navigation
[SPARK-60139][PYTHON] Remove dead code UNSUPPORTED_COMBINATIONS - #59343
Open
bearomorphism wants to merge 2 commits into
Open
bearomorphism wants to merge 2 commits into
bearomorphism wants to merge 2 commits into
Conversation
bearomorphism
marked this pull request as ready for review
October 11, 2026 03:49
bearomorphism
force-pushed
the
fix-unsupported-combinations-typing
branch
from
October 11, 2026 03:52
0d1aab7 to
ed00a6f
Compare
bearomorphism
marked this pull request as draft
October 11, 2026 04:02
bearomorphism
marked this pull request as ready for review
October 11, 2026 04:04
Contributor
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the unused
UNSUPPORTED_COMBINATIONSconstant frompython/pyspark/install.py, together with its import and dead loop intest_checked_versions.This supersedes the original annotation-only approach. The existing supported-version checks and explicit test rejecting Hive 1.2 remain unchanged.
Why are the changes needed?
History investigation shows that this constant has been unused by production code since September 2020:
without-hadoopor Hadoop 3.2.checked_versions. The empty declaration and test loop were left behind.# type: ignoreto silence mypy's missing-annotation error for the empty list.Before this cleanup, a repository-wide search found only the declaration, the test import, and the test loop. The loop executes zero iterations because the list is empty. Removing these leftovers is preferable to adding a type annotation to dead code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The following focused tests passed both before and after removal (2 tests):
Additional checks passed:
install.pysource usingpython/mypy.ini, without importing the parent PySpark package.git diff --check.UNSUPPORTED_COMBINATIONSreferences underpython.The network-dependent installation/download test was not run. An earlier package-aware mypy invocation encountered 23 errors elsewhere in PySpark; this is not a claim that the full package type check passes.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: pi 1.1.0