Skip to content

Add a type annotation and descriptive comment for UNSUPPORTED_COMBINATIONS - #59356

Closed
HsuehYi wants to merge 1 commit into
apache:masterfrom
HsuehYi:SPARK-60153-Improve-type-annotations
Closed

HsuehYi wants to merge 1 commit into
apache:masterfrom
HsuehYi:SPARK-60153-Improve-type-annotations

Conversation

@HsuehYi

@HsuehYi HsuehYi commented Oct 11, 2026

Copy link
Copy Markdown

What changes were proposed in this pull request?

This PR adds proper type annotations to UNSUPPORTED_COMBINATIONS in python/pyspark/install.py

Why are the changes needed?

Changes improve type checking.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Errors on install.py before Changes (delete # type: ignore):

starting mypy annotations test...
annotations failed mypy checks:
python/pyspark/install.py:38: error: Need type annotation for "UNSUPPORTED_COMBINATIONS" (hint: "UNSUPPORTED_COMBINATIONS: list[<type>]

After changes:
Verified with mypy that install.py has no type errors

Was this patch authored or co-authored using generative AI tooling?

No.

@bearomorphism

Copy link
Copy Markdown

I'm already fixing the issue: #59343

@gaogaotiantian

Copy link
Copy Markdown
Contributor

#59343 is favored for this specific issue.

@HsuehYi
HsuehYi deleted the SPARK-60153-Improve-type-annotations branch October 11, 2026 06:22
@HsuehYi
HsuehYi restored the SPARK-60153-Improve-type-annotations branch October 11, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants