Repository navigation
Teams meetings: mark the newest speaker, and log more of a nameless participant - #37
Merged
Merged
Conversation
…articipant The speaker history's first entry marked whoever spoke long ago; take the last. Log the history as it comes, and a nameless participant's devices.
The data channel's speaker history came once, on joining, and never again. The audio line offers dsh as an RTCP application message too, and the call registers a csrcInfo callback: both reach the call now, logged, and a JSON dsh among them counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in a meeting: the speaking ring was on the wrong person while its timing was right. The data channel's speaker history was read newest first; its last entry is taken now, and each history is logged with who it marks, so the next meeting confirms the order.
The two participants under
28:came with no name anywhere in their details (displayNameSource: "unknown"), so the log of a nameless participant now includes what the roster says of their devices.