Repository navigation
fix(verifier): reject ambiguous keys and update Bouncy Castle - #3
Merged
Merged
Conversation
Fail closed on normalized key collisions, malformed expiry and invalid pinned keys. Upgrade Bouncy Castle to 1.86 to remove advisories in the bundled cryptographic provider.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ascender1729
marked this pull request as ready for review
October 12, 2026 05:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject NFC-colliding keys during canonicalization and fail verification closed. Upgrade Bouncy Castle to 1.86 after advisory review.
Validation: all 11 existing and security JUnit tests pass with verified Bouncy Castle 1.86 artifacts and javac --release 11 on JDK 17. The Gradle plugin resolution path still needs hosted CI verification.