Skip to content

docs: fix dead ERC-7739 and ERC-7914 reference links - #1175

Open
ninglinLiu wants to merge 1 commit into
Uniswap:mainfrom
ninglinLiu:docs/fix-erc7739-erc7914-links
Open

ninglinLiu wants to merge 1 commit into
Uniswap:mainfrom
ninglinLiu:docs/fix-erc7739-erc7914-links

Conversation

@ninglinLiu

Copy link
Copy Markdown

Summary

Fixes two dead external reference links (both currently return 404), found by checking every non-Uniswap github.com link under content/:

Page Old link (404) New link
Smart Wallet → Concepts → ERC-7739 OpenZeppelin/openzeppelin-community-contracts/.../signers/ERC7739.sol. The file was removed from community-contracts in OpenZeppelin/openzeppelin-community-contracts#176 ("remove files that migrated to the vanilla repo") OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/cryptography/signers/draft-ERC7739.sol (same abstract contract ERC7739, now in the main OpenZeppelin Contracts repo)
UniswapX → Filling → FAQ (ERC-7914: Transfer From Native) ethereum/ERCs/blob/master/ERCS/erc-7914.md (the draft is not on master) ethereum/ERCs/blob/8380220.../ERCS/erc-7914.md, the same pinned commit already used on the Smart Wallet → ERC-7914 page

Type of change

  • Fix (typo, broken link, incorrect or outdated content)
  • New content (guide, page, code example)
  • Update to existing content
  • Other

How has this been verified?

  • curl -L returns 404 for both old URLs and 200 for both new ones.
  • git log in openzeppelin-community-contracts shows signers/ERC7739.sol deleted in 1f40eb5 (develop #176); the OpenZeppelin Contracts draft-ERC7739.sol declares abstract contract ERC7739 is AbstractSigner, EIP712, IERC1271.

Anything else reviewers should know?

Docs-only, 2 lines. Separate from #1173 and #1174. Prepared with AI assistance; I reviewed the change and checked every link listed above.

@github-actions

Copy link
Copy Markdown

Thanks for contributing to Uniswap Docs! 🦄

Quick heads up on how this repo works: the docs you see on developers.uniswap.org are built from a separate source repo. When we accept a change here, we port it over there, so your fix might show up on the live site before it lands in this repo.

Updates to this repo come in batches on a regular cadence. When yours is included, you'll be credited as a co-author on the commit, so the contribution counts on your GitHub profile and in Uniswap/docs.

We review every PR but can't merge everything. Either way, someone from the docs team will follow up here once we've taken a look.

One legal bit: by submitting a PR you agree your contribution is licensed under the repo's MIT license.

@github-actions

Copy link
Copy Markdown

Review summary

Reviewed the 2-line diff (two external reference link fixes).

Changes:

  1. content/protocols/smart-wallet/concepts/erc-7739.mdx — OpenZeppelin ERC-7739 reference link updated from openzeppelin-community-contracts/.../signers/ERC7739.sol (removed from that repo) to openzeppelin-contracts/.../signers/draft-ERC7739.sol.
  2. content/liquidity/uniswapx/filling/faq.mdx — ERC-7914 reference link updated from ethereum/ERCs/blob/master/ERCS/erc-7914.md to a pinned-commit URL.

Verification performed:

  • I couldn't make outbound network requests in this review environment to independently re-check live HTTP status, but I verified internal consistency: the exact same pinned commit hash (8380220418521ff1995445cff5ca1d0e496a3d2d) used in the faq.mdx fix is already used for the ERC-7914 reference on content/protocols/smart-wallet/concepts/erc-7914.mdx:14, so this change brings the two pages in line with each other, as the PR description claims.
  • The OpenZeppelin repo move (community-contracts → main contracts repo for ERC7739) described in the PR is plausible and consistent with known OZ restructuring of signer contracts into the main repo.
  • No other content, frontmatter, or surrounding prose was touched — scope matches the stated "docs-only, 2 lines" intent.
  • No broken MDX/Docusaurus syntax, no address/chain-ID changes, no promotional content.

Looks good to merge from a content-accuracy and formatting standpoint. Recommend a maintainer do a quick live click-through on the two new URLs before merge, just as final confirmation of the 200 status.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant