Repository navigation
docs: fix dead ERC-7739 and ERC-7914 reference links - #1175
ninglinLiu wants to merge 1 commit into
Conversation
|
Thanks for contributing to Uniswap Docs! 🦄 Quick heads up on how this repo works: the docs you see on developers.uniswap.org are built from a separate source repo. When we accept a change here, we port it over there, so your fix might show up on the live site before it lands in this repo. Updates to this repo come in batches on a regular cadence. When yours is included, you'll be credited as a co-author on the commit, so the contribution counts on your GitHub profile and in Uniswap/docs. We review every PR but can't merge everything. Either way, someone from the docs team will follow up here once we've taken a look. One legal bit: by submitting a PR you agree your contribution is licensed under the repo's MIT license. |
Review summaryReviewed the 2-line diff (two external reference link fixes). Changes:
Verification performed:
Looks good to merge from a content-accuracy and formatting standpoint. Recommend a maintainer do a quick live click-through on the two new URLs before merge, just as final confirmation of the 200 status. |
Summary
Fixes two dead external reference links (both currently return 404), found by checking every non-Uniswap
github.comlink undercontent/:OpenZeppelin/openzeppelin-community-contracts/.../signers/ERC7739.sol. The file was removed from community-contracts in OpenZeppelin/openzeppelin-community-contracts#176 ("remove files that migrated to the vanilla repo")OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/cryptography/signers/draft-ERC7739.sol(sameabstract contract ERC7739, now in the main OpenZeppelin Contracts repo)ethereum/ERCs/blob/master/ERCS/erc-7914.md(the draft is not onmaster)ethereum/ERCs/blob/8380220.../ERCS/erc-7914.md, the same pinned commit already used on the Smart Wallet → ERC-7914 pageType of change
How has this been verified?
curl -Lreturns 404 for both old URLs and 200 for both new ones.git login openzeppelin-community-contracts showssigners/ERC7739.soldeleted in1f40eb5(develop #176); the OpenZeppelin Contractsdraft-ERC7739.soldeclaresabstract contract ERC7739 is AbstractSigner, EIP712, IERC1271.Anything else reviewers should know?
Docs-only, 2 lines. Separate from #1173 and #1174. Prepared with AI assistance; I reviewed the change and checked every link listed above.