Repository navigation
docs: fix dead Foundry Book and Uniswap V3 Book links - #1176
ninglinLiu wants to merge 1 commit into
Conversation
|
Thanks for contributing to Uniswap Docs! 🦄 Quick heads up on how this repo works: the docs you see on developers.uniswap.org are built from a separate source repo. When we accept a change here, we port it over there, so your fix might show up on the live site before it lands in this repo. Updates to this repo come in batches on a regular cadence. When yours is included, you'll be credited as a co-author on the commit, so the contribution counts on your GitHub profile and in Uniswap/docs. We review every PR but can't merge everything. Either way, someone from the docs team will follow up here once we've taken a look. One legal bit: by submitting a PR you agree your contribution is licensed under the repo's MIT license. |
Review summaryReviewed the 4-file, 7-line diff that swaps 7 dead external links for working ones. Findings: no issues. The changes look correct and well-scoped:
Note: my sandbox doesn't have outbound network access, so I could not independently re-curl each URL; the above is based on cross-referencing URL patterns already in use elsewhere in this repo, which corroborates the author's stated manual verification. Nothing here warrants blocking. |
Summary
Fixes 7 dead external documentation links (all currently return 404), found by checking every non-GitHub external link under
content/. The Foundry Book moved frombook.getfoundry.shtogetfoundry.sh, and the old/reference/forge/*paths no longer resolve or redirect:book.getfoundry.sh/reference/forge/forge-test,forge-build,forge-scriptgetfoundry.sh/forge/reference/forge-test,forge-build,forge-scriptbook.getfoundry.sh/reference/forge/forge-verify-contract,forge-creategetfoundry.sh/forge/reference/forge-verify-contract,forge-creategetfoundry.sh/introduction/overviewgetfoundry.sh/introduction/getting-starteduniswapv3book.com/docs/introduction/uniswap-v3/uniswapv3book.com/milestone_0/uniswap-v3.html(the book's "Introduction to Uniswap V3" chapter)Type of change
How has this been verified?
curl -Lreturns 404 for every old URL and 200 for every new one; each new Foundry page is the matchingforge <command>reference page.book.getfoundry.shlinks in the repo (e.g./forge/deploying,/anvil/,/getting-started/installation) still redirect correctly, so they are left untouched.Anything else reviewers should know?
Docs-only, 7 lines across 4 files. Separate from #1173, #1174 and #1175. Prepared with AI assistance; I reviewed the change and checked every link listed above.