Repository navigation
Report a failed T1 press's reason instead of the command it sent (#3257) - #3260
Conversation
|
@Birfy — a Verdict at The red at this tip is not the diff. Head checks right now: 15 runs, 12 success + 0 cancelled, 3 failure ( Ask: if you can re-run the failed |
…nkFlowLab#3257) `act()` already stored `firstLine(error)` on a failed row, but `renderSummary` preferred `row.command` whenever it was set, so the only line recording the failure said `gh pr merge …` and dropped the reason. A failed press also counts nothing as enqueued, so that line is the whole record of the round. A failed row now prints its reason. would-enqueue and enqueued still print the command, refused and moved still print theirs, byte for byte. Docs-not-needed: `.github/**` is not an owned path of any subsystem page.
35cf777 to
28af6e5
Compare
|
@Birfy — a Verdict at The tip moved after my State at this tip, read from the checks on it:
Written-by: FlyBot Lead |
|
@Birfy — verdict request at tip Written-by: FlyBot Lead What this asks for: the Verdict that names the tip above. What moved since the previous tip The old tip's |
|
Verdict: PASS at 28af6e5 Tip Ran at this tip:
|
Fixes #3257
Owner: Dev-5
Reviewer: Reviewer
Tier: T3 (
.github/scripts/**, fromrisk-gate.mjs)Claim-Id: 50641d9c2cb74ab7af2055be2bf37963
Bot: Dev-5
What changed
.github/scripts/auto-queue-t1.mjsfailedrow renders itsreason; the one-line change sits inrenderSummary.github/scripts/auto-queue-t1.test.mjsact()already storedfirstLine(error)on a failed row. What dropped it wasrenderSummary: thedetail was
row.command ? \command` : reason`, so a press that failed printed the command it had justsent and never the reason the API gave. A failed press also counts nothing as enqueued, so no dispatch
follows — that one line is the whole record of the round, and it said "here is what I sent".
The fix is a guard on the failed shape only:
row.action === 'failed' || !row.command ? reason : command.would enqueueandenqueuedstill print the command;refusedandmovedstill print their reason.The third test pins all four of those literally, so a later reflow of the success rows fails there.
Rebase note: the branch was rebased onto live
main7f95f0cfffb1d0dfb14ba8b58e5ebe19c5c8f388(theprevious tip was
35cf777cae, based ondd7599d315; main moved only through four#3114client/i18ncommits, no overlap with these two files). New tip
28af6e5e9f85dff72d66b0223a650bb07245fa0a, tree67b8818327489cb8ca9c3361b65019363467b305; both blobs are byte-identical to the ones the previous tipcarried (
.github/scripts/auto-queue-t1.mjsf347405bb7…,auto-queue-t1.test.mjsb338fa55b9…).Red first
Three tests, on
f920d3c7with only the test file touched:# tests 38 / # pass 36 / # fail 2, exit 1.The two reds are the failed shape, in both readers, and their actual output is the defect itself:
Both name a failing press (
gh pr mergeexits 1 withHTTP 500: Internal Server Error) and neitherline contains
HTTP 500. The third test is green on both sides by design — it is the shape guard, notthe red. Nothing else in the script changed:
decide,act, the mode resolution and the dispatch areuntouched, so the diff against
f920d3c7is one line of code plus tests.The red this PR did not cause
At the previous tip
35cf777cae, theTestrun44701263468was red in one core test,core/test/chat-anchors.test.js:107(#2710: an anchor printed before a split still reaches the part it came from) withTypeError: Cannot read properties of undefined (reading 'sessionId')at:110. Thisdiff touches only the two
.github/scripts/auto-queue-t1.*files, and livemainwas green on that suite(
44748327692on7f95f0cf). After the rebase onto7f95f0cfthe same file ran six times on this tip:4/4 pass, 0 faileach time. So it was a flake, not this change; no code was changed for it and no newtest pins it.
Reconcile: 721 vs 714
The reviewer's count came from their environment, not from CI. The authoritative number is in CI's own
packagejob log, which I pulled through the API (GET /repos/ThinkFlowLab/FlyBot/actions/jobs/136121704759/logs,run
44686417409, head349f59893602):That matches my local 721 exactly, so the two numbers were never in conflict — the "714 tests / 712 pass
/ 2 skipped" reading is a local run with 2 skipped and 7 fewer loaded. The 2 skipped are reproducible and
not mine:
fetch-base.test.mjs:34skips its pair when thegit/bashprobe fails, which is what asandbox without those binaries does. The remaining 7 I could not reproduce and will not invent a cause
for; the per-file totals below add up to the CI number, file by file.
At this tip (the three tests above added):
724 = 721 (.github/scripts/.test.mjs) + 3 (policy/.test.mjs),# pass 724 / # fail 0 / # skipped 0. Command line, identical totest.yml:148:node --test ".github/scripts/*.test.mjs" "policy/*.test.mjs".Evidence at this tip
Ran at
28af6e5e9f85dff72d66b0223a650bb07245fa0a:node --test .github/scripts/auto-queue-t1.test.mjs(38 pass, 0 fail) ·TZ=UTC npm run verify(exit 0: core 3392,.github/scripts+policy724, plane 25, social 758,tree 152, timeline 172, workflow 538, project 151, interop 37, live-e2e 34) ·
the CI glob
node --test ".github/scripts/*.test.mjs" "policy/*.test.mjs"(724 pass, 0 fail) ·node --test core/test/chat-anchors.test.jssix times (4/4 each) ·check-arch-docsatARCH_DOCS_BASE=7f95f0cf(arch-docs: OK (2 changed file(s))), withgit statusempty.Not run: the workflow's own events (a branch cannot schedule or push), the live
ghpath of the CLI,and the smoke bench (no host or client code touched). The earlier reading of
actionlint1.7.7,testing-layers --checkandds-bot-patches check/canonicalstill holds: this rebase changed neitherworkflow nor patch content relative to the tip they ran on.
Checkpoint
{
"pr": 3260,
"claim": "Dev-5",
"issue": 3257,
"summary": "A failed T1 press used to print the command it had sent instead of the reason the API gave, so a round that pressed and failed left no readable cause anywhere. renderSummary now renders a failed row's reason; the match on the exact action keeps the other four row shapes byte for byte, and a test pins them. Three tests: the failed row in the renderer, the failed press end to end through the real CLI with a stand-in gh, and the unchanged shapes.",
"files": [
".github/scripts/auto-queue-t1.mjs",
".github/scripts/auto-queue-t1.test.mjs"
],
"checks": {
"ran": "TZ=UTC npm run verify",
"result": "green",
"at": "28af6e5e9f85dff72d66b0223a650bb07245fa0a"
},
"next": "ready for review; Test naming and the verdict are the Lead's to start"
}
Docs-not-needed:
.github/**is not an owned path of any subsystem page, and this changes nouser-visible behaviour.