Repository navigation
Read the Project plugin's purpose on the Plugins page in the window language (#3114) - #3271
Conversation
…anguage (#3114) Docs-not-needed: one dictionary key, one test and one changelog fragment; no component or structure change.
|
Base check at 2026-11-20T15:58Z: Re-ran everything at tip |
Spot-check at the tip, before the queue (enqueue node)Read at 2026-11-20T16:02Z–16:07Z via GitHub REST:
Checks at the tip (20 total, all terminal): 17 success / 2 skipped / 1 cancelled, 0 failure. Enqueue preconditions: tier T1 → no PASS required; no Enqueued at 2026-11-20T16:06:37Z: entry |
Written-by: Dev
Fixes #3270
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: one dictionary key, one test and one changelog fragment; no component or structure change.
What changed
Before: a Chinese window drew the Project plugin's purpose as the English sentence
Run a Project: Project State, its board, its own Chief, its team and its assistant.on Settings → Plugins. Both faces of that row — the installed one throughSwitchRow.hint(core/src/client/settings.js:90) and the not-installed one through the install hint (:84) — already draw${plugin.package} — ${t(plugin.purpose)}; the four other plugin purposes had whole-sentence keys in the dictionary and this fifth one had none, sot()returned the key itself.After: one whole-sentence key in
core/src/client/i18n.js, right after'Run workflow graphs across several Bots.'—Run a Project: Project State, its board, its own Chief, its team and its assistant.→运行一个项目:Project State、它的看板、它自己的 Chief、它的团队和助手。.core/src/client/settings.jsis byte-identical (the draw point stayst(plugin.purpose), twice); no component, no structure, no mapping table. An English window is unchanged (with no localet()returns the key), and the plugin names (Bot Social/Tree/Timeline/Workflow/Project) are not translated — that is an owner naming decision and a separate cut.Project StateandChiefkeep the dictionary's existing English form, asREADME.zh.md:79and'Project Chief': '项目 Chief'already do.The new case reads the five
purposestrings out ofcore/src/host/plugins.jswith/purpose: (['"])((?:(?!\1).)+)\1/g, so a sixth plugin shipped without a Chinese key fails it too — it guards the class, not only this key. It asserts three things: with no locale the English sentence is still on the page; with a zh locale none of the five English purposes is; and the page reads运行一个项目.Hand-written: 3 files / +22/−2 = 24 lines (
core/src/client/i18n.js+2/−0,core/test/plugin-installed-faces.test.js+19/−2,changelog.d/3114-cut-37-plugin-purpose.fixed.md+1/−0). Generated, never hand-edited:core/client.js(+2) and three patch artifacts (0001,0008,files/test/plugin-installed-faces.test.js). Whole cut: 7 files / +49/−6.Verification at the tip
Tip SHA:
53adc4b1162a796fb8cdd51242682ba60cca383b(treeb9091eb696b8a814ed6f0e7cb7a44bf0be0959c1, matching the local commit byte for byte)Ran at this tip:
Two runs sit on a tree I reconstructed here rather than a fresh
git clone: this box cannot reachgithub.com(onlyapi.github.com), so the working copy is a tree whose shafc2b56dc00924e47114dd7d20a4cbff79d8378fdI checked againstGET /repos/ThinkFlowLab/FlyBot/commits/7f95f0cf…before writing anything. The branch tip was then built with the git data API whose tree sha (b9091eb6…) equals the local one, so the pushed bytes are the tested bytes.Red first, on the clean base with the implementation untouched (only the new test in the tree):
# tests 7 / # pass 6 / # fail 1,not ok 7, error text"Run a Project: Project State, its board, its own Chief, its team and its assistant." still reads English in a zh window. At the tip the same command is 7/7/0; clean main on the same file is 6/6/0.Risk gate over the seven changed paths, objects carrying
patch(the shape the PR files API serves):T1 0 24 3 4— hand-written 24 lines / 3 files, 4 generated paths. The names-only trap reproduced on the same diff (T0 0 0 7 0), and the no-patchtrap reproducesT3. Budget leaves 376 lines / 17 files. The forbidden regex (core/src/host/,plugins/,.github/,scripts/,about.js,capability-settings.js,sidebar.js,project-board.js) hits 0 with the positive control on the same regex hitting 4;core/src/client/settings.jsis absent from the diff (0) whilegrep -c "t(plugin.purpose)"there is 2; the fouri18n-*.baseline.jsonare absent (0);git diff … core/src/client/i18n.js | grep -c '^-[^-]'is 0.Not run (and why): the full
TZ=UTC npm run verify. The sharedcore/node_moduleshere carries onlyesbuildand a few packages — no@deepseek-ai/dsh-*harness and nojsdom— so the core suite cannot start on this box, and the brief forbidsnpm ci/npm run harness; CI carries the full suite at this tip. Everything runnable here ran at this tip: the affected test file, the five i18n gates, the four baseline counts, the bundle check, the patch checks, changelog, the mojibake byte scan and arch-docs.Checkpoint
{ "pr": 3271, "claim": "Dev", "issue": 3270, "summary": "The Project plugin's row on Settings → Plugins drew its purpose in English in a Chinese window: the draw point already read t(plugin.purpose), but the dictionary had no key for the fifth purpose. One whole-sentence key in core/src/client/i18n.js now reads 运行一个项目:…; no component, no structure and no draw point change, and an English window is unchanged. The new test reads all five purposes from the host catalogue, so a sixth plugin shipped without a key fails it: red first 7/6/1, after the fix 7/7/0. The bundle and the generated patch artifacts were regenerated, never hand-edited.", "files": [ "core/src/client/i18n.js", "core/test/plugin-installed-faces.test.js", "changelog.d/3114-cut-37-plugin-purpose.fixed.md", "core/client.js", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0008-client-bundle.patch", "patches/ds-bot/files/test/plugin-installed-faces.test.js" ], "checks": { "ran": "plugin-installed-faces 7/6/1 red then 7/7/0 green; five i18n gates 41/41/0; baselines 12/9/46/2; npm run build; ds-bot-patches generate/canonical/check; build-client --check; changelog 18; mojibake 1787; arch-docs OK (7); risk gate T1 0 24 3 4", "result": "green", "at": "53adc4b1162a796fb8cdd51242682ba60cca383b" }, "next": "none — ready for review" }