Repository navigation
Read a paused friend chat's notice in the window's language (#3114) - #3241
Conversation
|
Verdict: PASS at 574bc69 Ran at this tip: Tier T2 (recomputed at this tip: plugin code + test paths; 142 lines / 11 files, 5 generated; whole diff 163 lines / 16 paths, inside 250/12). Red first: with only the new test kept and Deviations from the spec, judged independently:
Scope: the only Baselines are 12 / 9 / 46 (plugins 12, template 9, missing 46; missing-zh 2): Body: |
Written-by: Dev
Fixes #3238
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: user-visible zh copy only; no subsystem behaviour, API or ownership changed.
What changed
The quiet card a friend chat draws above the composer once Bot Social has paused that chat was bare English in a Chinese window: the title
Chat paused, the noteBot Social paused the last chat with this Bot.(or… ({reason}).) and the follow-upSend your message again: it starts a new chat.. All three now go through the file's owntr(), with the note and the follow-up joined by{note}so the card keeps today's "one reason + one next step" layout in the samefs-draft. Four keys land in the mainZHdictionary incore/src/client/i18n.js, and Bot Social's ownreasonis still shown exactly as the server sent it, untranslated, inside the full-width parentheses. Behaviour, slots, classes and CSS are untouched.Verification at the tip
Tip SHA: 574bc69
Ran:
node --test plugins/social/test/paused-chat-i18n.test.js— red first on main:5 / 2 / 3; at this tip:5 / 5 / 0.cd plugins/social && DSH_HARNESS=… npm test—757 / 757 / 0(main: 752).node --test core/test/i18n.test.js core/test/i18n-plugins.test.js core/test/i18n-missing-entries.test.js core/test/i18n-template-draws.test.js core/test/i18n-plugins-missing-zh.test.js—39 / 39 / 0.*-i18n.test.jsfiles —33 / 33 / 0.npm run verify(repo root,TZ=UTC) — all suites green; core3354tests,0fail,1pre-existing skip.(cd core && node scripts/build-client.mjs --check)rc 0;node scripts/ds-bot-patches.mjs checkthreeok;node scripts/ds-bot-patches.mjs canonicalafter the commit —generate is a no-op.node .github/scripts/changelog.mjs check,node .github/scripts/check-mojibake.mjs --check,core/scripts/check-arch-docs.mjs— rc 0.plugins / template / missing:12 / 10 / 47→12 / 9 / 46shrank by exactly the two pins of this card.Not run: no release, no deploy, no ruleset change; the smoke test (no
index.jsorsrc/host/change).Checkpoint
{ "pr": 3241, "claim": "Dev", "issue": 3238, "summary": "A friend chat that Bot Social paused drew its notice, its reason line and its 'send your message again' line as bare English in a Chinese window. All three now go through the plugin's own tr(), the note and the follow-up are joined with {note} in the same fs-draft, and four zh keys land in the main ZH dictionary. Bot Social's reason is still shown exactly as the server sent it, untranslated. Behaviour, slots, classes and CSS are untouched.", "files": ["plugins/social/client.js", "core/src/client/i18n.js", "plugins/social/test/paused-chat-i18n.test.js", "changelog.d/3114-paused-chat-zh.fixed.md"], "checks": { "ran": "npm run verify; cd plugins/social && npm test; node --test plugins/social/test/paused-chat-i18n.test.js", "result": "green", "at": "574bc690b2213a4cd7487cbc6b497762683e3f9b" }, "next": "none — ready for review" }