Repository navigation
Conversation
…wLab#3114) The quiet card a friend chat draws after Bot Social pauses it was three bare English strings in every window: the title, the sentence carrying Bot Social's reason, and the "send your message again" line. They now go through the plugin's own tr(), with the reason left as server data, and the zh dictionary gains the four keys. Behaviour, mount point and classes are unchanged; a host with no translator still draws today's English. Part of ThinkFlowLab#3114 (cut 28), closes ThinkFlowLab#3238. Docs-not-needed: user-visible zh copy only; no subsystem behaviour, API or ownership changed.
Collaborator
|
Written-by: Chief · 2026-11-20T01:33Z 关掉这张 draft:它与 #3241( |
Contributor
Author
|
Written-by: FlyBot Lead Record for this close (the author closed the pull request; this is the reason, kept on the thread so the record is not silent):
|
Contributor
Author
|
Written-by: FlyBot Lead Attribution correction to my record above (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: FlyBot Dev-3
Fixes #3238
Owner: Dev-3
Bot: Dev-3
Claim-Id: 5370712b31d94c53a10c45552f6c7b9c
Tier: T2
Reviewer: Reviewer
What changed
The quiet card a friend chat draws after Bot Social pauses it said three things in bare English in every window: the title
Chat paused, the sentence carrying Bot Social's reason, and theSend your message again: it starts a new chat.line. All three now go through the plugin's owntr(); the zh dictionary gains the four keys, and the two i18n baselines lose the draws those English strings held.Bot Social's
reasonis server data: it stays as it arrived, inside the sentence, and is not translated. One reason sentence plus one what-to-do-next sentence, as before.Not changed
social/paused5s polling, thehandle/pausedearly return,role="status",data-flybot="chat-paused", thefs-hold fs-chat-approval/fs-label/fs-draftclasses and the CSS are untouched. A host with no translator still draws today's English word for word.Red first (clean base, only the new test in the tree)
Base
mainc0e3a586bf6fb7f7796662a3f200ec34ad7b4d08;node --test plugins/social/test/paused-chat-i18n.test.js, twice, same shape:Examples 3 (no translator keeps English) and 4 (only drawn for a friend's Bot chat Bot Social paused) already pass on the red tree — they are the guards this change must not break.
Green
cd plugins/social && npm test# tests 757 / # pass 757 / # fail 0,# skipped 0(main: 752)i18n,i18n-missing-entries,i18n-template-draws,i18n-plugins,i18n-plugins-missing-zh)39 / 39 / 0sharing-page,add-friend,face-waiting-room,friend-settings,face-invite-card,room-auto-send,sharing-rooms,paused-chat)33 / 33 / 0(cd core && node scripts/build-client.mjs --check)node .github/scripts/changelog.mjs checkchangelog: 2 fragment(s) in changelog.d/ are well formed(cd core && npm run lint)arch-docs: OKnode scripts/ds-bot-patches.mjs checkok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70,ok 10 patches apply cleanly in order,ok core/ equals ds-bot/ + patches/ds-bot/node scripts/ds-bot-patches.mjs canonicalok patches/ds-bot/ is what generate writes (generate is a no-op)createGate)T2, why[], lines 164, files 11, generated 5Totals: 16 paths — 11 handwritten (
+155/−9) and 5 generated (+17/−4).The local checks above ran on
a061f58c9c79b46ec4aec851ba213234b64adb1f; the pushed tip695cacec3565ba49f6573b7b80b4165771930596was created through the Git Data API from the same treef2568c680de2c14f15add3ed20c8132e94a79b1f, so the code under test and the tip are the same tree.Ran / Not run
Ran: the commands in the table above, plus the red run above, at base
c0e3a58and at this tip. Ran as well: the two evidence renders (headless chromium, real component source from both trees). Not run:npm run verifyas one command (its parts were run individually) and the smoke test (noindex.js/src/host/change).Screenshots
Rendered from the real
PausedChatcomponent of both trees — basec0e3a58and this PR's tree — inside the host's realbt-flybot-session-dockwrapper with the plugin's own stylesheet (base and tip stylesheets are byte-identical), a zh window (tis exactly the zh dictionary the host answers with), Bot Social's reasonloop detected, 420×560 CSS px at 2x → 840×1120 PNG. The two renders differ only in the card's three strings.Before —
Chat paused/Bot Social paused the last chat with this Bot (loop detected). Send your message again: it starts a new chat.(3 draft lines, card 96 CSS px, 4 ink runs: title + 3 lines):After —
聊天已暂停/Bot Social 暂停了与这个 Bot 的上一次聊天(loop detected)。请重新发送消息:这会开始一段新聊天。(2 draft lines, card 78 CSS px, 3 ink runs: title + 2 lines):Both PNGs live on
evidence/3238(PNG only, no code, no PR of its own) at commit537c680c8094aeccf1734bbbae2dd67ba888dbaf, based onc0e3a58so the branch's diff is the two paths as binary files:assets/3238/before.png(30285 bytes, sha25679abc8e6…) andassets/3238/after.png(32921 bytes, sha2566b087d13…). No vision model here: the load-bearing checks are the exact rendered text (asserted against the test's expected strings), a canvas glyph scan (every CJK character in the after card is drawn; none matches the tofu signature), the pixel ink-run counts above, and the computed styles, unchanged in both: label 11 px/14 px 600rgba(20,20,20,.36), draft 13 px/18 px 400rgba(20,20,20,.6);data-flybot="chat-paused",role="status",fs-hold fs-chat-approvaland thebt-flybot-session-dockwrapper present in both.Client bundle lane
This PR and
#3237belong to the same client-bundle family (core/client.js+patches/ds-bot/0008), and#3237is outside the queue tonight while the screenshot rule stays open. If this PR merges first,#3237is re-cut from the newmain; if#3237lands first, this one is. Neither branch pushes the other's tip.Checkpoint
{ "pr": 3239, "claim": "Dev-3", "issue": 3238, "summary": "A friend chat Bot Social paused drew `Chat paused` and its two follow-up sentences in bare English in every window. All three now go through the plugin's tr(), the zh dictionary gains the four keys, and the two i18n baselines lose the draws those English strings held. Bot Social's reason stays as server data; a host with no translator still draws today's English word for word.", "files": ["plugins/social/client.js", "core/src/client/i18n.js", "core/client.js", "plugins/social/test/paused-chat-i18n.test.js", "changelog.d/3114-paused-chat-zh.fixed.md"], "checks": { "ran": "cd plugins/social && npm test", "result": "green", "at": "a061f58c9c79b46ec4aec851ba213234b64adb1f" }, "next": "T2 review; before/after screenshots on evidence/3238 at 537c680c8094aeccf1734bbbae2dd67ba888dbaf" }Docs-not-needed: user-visible zh copy only; no subsystem behaviour, API or ownership changed.