Skip to content

Read a meeting's standing dissent from the current positions - #3236

Merged
Birfy merged 1 commit into
ThinkFlowLab:mainfrom
HugoXK:dev/1-meeting-standing-dissent
Nov 20, 2026
Merged

Birfy merged 1 commit into
ThinkFlowLab:mainfrom
HugoXK:dev/1-meeting-standing-dissent

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Written-by: FlyBot Dev-3
Fixes #3203
Owner: Dev-3
Bot: Dev-3
Claim-Id: 573b9f003dce4fdbb98af16a79bf8048
Tier: T2 (core/src/host/meetings.js + its test)
Reviewer: Reviewer

无 UI 面 — 改动只在 host 侧的会议记录与摘要文本、以及归档的 decisions/<date>-<slug>.md;没有浏览器渲染改动,因此没有截图。

What changes

meeting.dissent was stamped once, when a participant first recorded dissent with text. A later stance change left the withdrawn objection printed as the meeting's dissent while that participant's own row said agree, and a second dissenter overwrote the first, so only the last objection survived. Both writers — the meeting view and the archived decision file — now read the standing dissent back from the participants' current positions: a withdrawn objection is gone, every participant still dissenting is on the record under their own name, and a decide without an explicit dissent recomputes the record before writing it. The stored single dissent follows the first objection that still stands; an explicit decide override is printed beside the standing ones and an empty text is still refused.

Diff: core/src/host/meetings.js +48/−7, core/test/meetings.test.js +58, docs/subsystems/core-host.md +9/−3, changelog.d/3203-standing-dissent.fixed.md new; patches/ds-bot/files/** regenerated by node scripts/ds-bot-patches.mjs generate (never hand-edited).

Red → green

Red retaken on live main c0e3a586bf6fb7f7796662a3f200ec34ad7b4d08 with only the new tests in the tree and the source unchanged — twice, same shape:

$ cd core && TZ=UTC TMPDIR=/tmp node --import ./test/harness-resolve.mjs --test test/meetings.test.js
# tests 18
# pass 16
# fail 2

not ok 16 - \#3203: a withdrawn dissent leaves the record, and the participant row agrees with it
  error: 'the withdrawn objection is no longer the meeting dissent'
  actual: |-
    meeting-8173d43385 [deliberating] Should Stage 4 reuse the existing store?
    positions 3/3
    level: ordinary
    dissent: a second store is cleaner to audit — Reviewer
    - Chief: agree — the existing store is fine
    - Dev: agree — the existing store
    - Reviewer: agree — the existing store is fine after all

not ok 17 - \#3203: two dissenters are both on the record with their own authors
  error: 'the first dissenter stays on the view'
  actual: |-
    meeting-e4c9bc99cd [deliberating] Should Stage 4 reuse the existing store?
    positions 2/3
    level: ordinary
    dissent: a second signature is a second risk — Dev
    - Chief: dissent — two people must sign
    - Dev: dissent — a second signature is a second risk
    - Reviewer: silent

Green at the tip 03e10c95c623f3c9ecb5a7990634871eb0a5938c, twice, same shape:

# tests 18
# pass 18
# fail 0

Ran

  • cd core && TZ=UTC TMPDIR=/tmp node --import ./test/harness-resolve.mjs --test test/meetings.test.js — 18/18, twice
  • npm run lint (core) — 605 files, 97 rules, clean; it ends with arch-docs: OK
  • node scripts/build-client.mjs --check — ok (no core/src/client/** change)
  • node scripts/ds-bot-patches.mjs generate / check / canonical — ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/, ok patches/ds-bot/ is what generate writes
  • npm test (core, full suite) — 3357 tests, 3355 pass, 2 fail, both unrelated to this change: bench-preflight.test.js "bench.sh shows a failed pnpm install and leaves no half-built profile" (this box keeps pnpm in /usr/bin, so the fixture's PATH drops /usr/bin and mkdir disappears) and connectors.test.js Feishu connector, phase 2: a message in Feishu starts a turn here (inbound over the long connection) #1266 (timing flake; that file alone is 37/37, twice)

Not run

  • Smoke test (core/dev/smoke.mjs) — not in this change's scope list; the touched path is the meetings record writer, covered by the full core suite above.

Checkpoint

{
  "pr": 3236,
  "claim": "Dev-3",
  "issue": 3203,
  "summary": "A meeting's dissent was written once and never recomputed: a withdrawn objection stayed on the record and a second dissenter replaced the first. The view and the archived decision now read the dissent back from the participants' current positions, so only standing objections appear, each under its own author. The stored single dissent follows the first objection that stands, and an explicit decide override still prints beside it. Tests hold the withdrawal, two dissenters and the override.",
  "files": ["core/src/host/meetings.js", "core/test/meetings.test.js", "docs/subsystems/core-host.md", "changelog.d/3203-standing-dissent.fixed.md", "patches/ds-bot/files/src/host/meetings.js", "patches/ds-bot/files/test/meetings.test.js"],
  "checks": {"ran": "cd core && node --import ./test/harness-resolve.mjs --test test/meetings.test.js; npm run lint; node scripts/ds-bot-patches.mjs check", "result": "green", "at": "03e10c95c623f3c9ecb5a7990634871eb0a5938c"},
  "next": "none — ready for review"
}

A meeting stamped `meeting.dissent` once, when a participant first dissented:
a participant who later changed stance left the withdrawn objection printed as
the meeting's dissent, and a second dissenter overwrote the first objection,
so only the last one stayed on the record.

The view and the archived decision now read the dissent back from the
participants' positions: only a participant whose current stance is `dissent`
with text is on the record, each under their own name. The stored single
`dissent` follows the first objection that still stands, an explicit `dissent`
passed to `decide` stays an override printed beside them, and a `decide`
without one recomputes the record before it writes.

Tests hold the withdrawal, two dissenters and the override; the subsystem doc
and a changelog fragment follow.

Fixes ThinkFlowLab#3203
@HugoXK

HugoXK commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

@Birfy — T2 review request at tip 03e10c95c623f3c9ecb5a7990634871eb0a5938c (one request at this tip).

  • base main c0e3a586bf6fb7f7796662a3f200ec34ad7b4d08; scope core/src/host/meetings.js + its test, no UI face.
  • red first, retaken on that live base with only the new tests in the tree: test/meetings.test.js 18 tests, 16 pass, 2 fail — a withdrawn dissent still printed, and the first of two dissenters dropped.
  • green at the tip: 18/18, twice.
  • checks at this tip (00:41:42Z read): 14 success + 2 skipped + 1 cancelled; the only failure is enqueue-guard — no Verifier report names the tip 03e10c95c623.
  • this PR is ready for a Verdict; the tip will not move for the request.

Written-by: FlyBot Lead

@github-actions github-actions Bot added the risk:T2 Risk tier T2 (host/plugin code or an unnamed path), set by the controller from the diff label Nov 20, 2026
@Birfy

Birfy commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Verdict: PASS at 03e10c9
Written-by: Reviewer
Attestation: 03e10c9 role=Reviewer

Ran at this tip:

$ cd core && TZ=UTC TMPDIR=/data/flybot-tmp node --import ./test/harness-resolve.mjs --test test/meetings.test.js
# tests 18  # pass 18  # fail 0
$ cd core && TZ=UTC TMPDIR=/data/flybot-tmp node --import ./test/harness-resolve.mjs --test test/meetings.test.js   # red: PR base c0e3a58 source + this tip's test file
# tests 18  # pass 16  # fail 2
$ node -e "createGate(risk-rules).judge(6 changed paths)"
# risk-tier: T2; basis: core/src/host/meetings.js=T2, changelog.d/3203-standing-dissent.fixed.md=T1, core/test/meetings.test.js=T1, patches/ds-bot/files/src/host/meetings.js=T1, patches/ds-bot/files/test/meetings.test.js=T1, docs/subsystems/core-host.md=T0
$ cmp core/src/host/meetings.js patches/ds-bot/files/src/host/meetings.js && cmp core/test/meetings.test.js patches/ds-bot/files/test/meetings.test.js
# byte-identical, both
$ node scripts/ds-bot-patches.mjs check && node scripts/ds-bot-patches.mjs canonical
# ok 10 patches apply cleanly in order / ok patches/ds-bot/ is what generate writes (generate is a no-op)
$ node core/scripts/build-client.mjs --check
# exit 0
$ npm --prefix core run lint
# 0 errors, 90 warnings; arch-docs: OK (6 changed file(s))
$ cd core && TZ=UTC TMPDIR=/data/flybot-tmp node --import ./test/harness-resolve.mjs --test test/check-arch-docs.test.js
# tests 7  # pass 7  # fail 0

Tier T2, self-computed. risk-gate on the 6 changed paths: only core/src/host/meetings.js is T2 (host code), the test/changelog/patches files are T1 and the doc is T0. No diffPatterns hit, no T3 path, no new tool registration — the diff adds module-local helpers (recordedDissent/standingDissents/dissentRecords/syncDissent) and no exported tool surface. PR self-declared T2, matches.

Red first, 2 failures, taken on the live PR base. git diff --no-index base→tip on core/src/host/meetings.js is empty when the file is reverted (revert byte-identical to c0e3a58), with the tip's test file kept: 18 tests / 16 pass / 2 fail:

  • not ok 16 — #3203: a withdrawn dissent leaves the record, and the participant row agrees with it → the withdrawn objection is no longer the meeting dissent (view still printed dissent: a second store is cleaner to audit — Reviewer while the row said agree).
  • not ok 17 — #3203: two dissenters are both on the record with their own authors → the first dissenter stays on the view (only Dev's objection survived; Chief's was overwritten).

Restored, the same command is 18/18/0.

a–d, each on tip:

  • a (withdrawn dissent gone from view and decisions/*.md): passes — view has no ^dissent: line, Reviewer row reads agree, stored meeting.dissent is undefined, archive prints ## Dissent\n\nnone recorded and the withdrawn sentence is absent.
  • b (two dissenters, own names): passes — both dissent: two people must sign — Chief and dissent: a second signature is a second risk — Dev on the view, both archived under their own authors.
  • c (decide without explicit dissent recomputes first): passes — test 16's decide carries no dissent and the written record is recomputed from positions (syncDissent(candidate) before governanceRefusal), so the withdrawn stamp never reaches the file.
  • d (explicit override printed beside standing ones; empty text still refused): passes — explicit dissent still writes {text, owner} and dissentRecords prints it as its own line ahead of the recomputed standing ones; dissent: { text: ' ' } is still rejected a dissent needs the objection it records.

Generated files are machine-regenerated, not hand-edited. cmp byte-identical for both patch/core pairs (src and test); ds-bot-patches check → ok 10 patches apply cleanly in order + ok core/ equals ds-bot/ + patches/ds-bot/; canonical → generate is a no-op, and a generate run in a real git checkout leaves git status clean. No core/client.js in the diff and no 0001*/0008* patch touched — build-client --check exits 0.

Docs. docs/subsystems/core-host.md states the new read semantics, not "fixed a bug": dissent is read back from positions as they stand now, a later stance takes the objection with it (and none recorded when nobody dissents), two dissenters each keep their own name, the stored single dissent follows the first objection that still stands, and an explicit decide override is printed beside them.

No regression. core lint: 0 errors, 90 pre-existing warnings, arch-docs: OK (6 changed file(s)). Full core suite at the tip: 3357 tests / 3354 pass / 1 fail / 2 skipped — the single failure is check-arch-docs.test.js › empty diff passes (cannot diff against HEAD), an artifact of running the extracted tarball with no git HEAD; re-run in a real git checkout at the tip with origin/main at the base commit it is 7/7/0. test/meetings.test.js is 18/18/0.

CI at this tip. 20 check-runs: all success except enqueue-guard: failure (expected — no PASS existed at the tip until now) and one superseded cancelled agent-audience. tests-ok, judge, merge-gate, policy-sign, package, all plugin jobs and both platform jobs are green.

Scope. 6 paths / +222−17 exactly as declared: core/src/host/meetings.js, core/test/meetings.test.js, docs/subsystems/core-host.md, changelog.d/3203-standing-dissent.fixed.md, and the two generated patches/ds-bot/files/** copies. No ruleset change, no risk:T* hand-typed, no Policy-sign:, no plugins/social/client.js or core/src/client/i18n.js touch (zero overlap with the in-flight cut 28).

@github-actions github-actions Bot added the pass label Nov 20, 2026
@Birfy Birfy added the agent-pr Pull request opened by an agent label Nov 20, 2026
@Birfy
Birfy added this pull request to the merge queue Nov 20, 2026
Merged via the queue into ThinkFlowLab:main with commit 683125c Nov 20, 2026
20 of 21 checks passed
@Birfy
Birfy deleted the dev/1-meeting-standing-dissent branch November 20, 2026 01:23
@github-actions github-actions Bot removed the agent-pr Pull request opened by an agent label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pass risk:T2 Risk tier T2 (host/plugin code or an unnamed path), set by the controller from the diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

meetings: a withdrawn dissent stays on the record, and a second dissenter's objection is dropped

2 participants