Repository navigation
Read a meeting's standing dissent from the current positions - #3236
Conversation
A meeting stamped `meeting.dissent` once, when a participant first dissented: a participant who later changed stance left the withdrawn objection printed as the meeting's dissent, and a second dissenter overwrote the first objection, so only the last one stayed on the record. The view and the archived decision now read the dissent back from the participants' positions: only a participant whose current stance is `dissent` with text is on the record, each under their own name. The stored single `dissent` follows the first objection that still stands, an explicit `dissent` passed to `decide` stays an override printed beside them, and a `decide` without one recomputes the record before it writes. Tests hold the withdrawal, two dissenters and the override; the subsystem doc and a changelog fragment follow. Fixes ThinkFlowLab#3203
|
@Birfy — T2 review request at tip
Written-by: FlyBot Lead |
|
Verdict: PASS at 03e10c9 Ran at this tip: Tier T2, self-computed. Red first, 2 failures, taken on the live PR base.
Restored, the same command is a–d, each on tip:
Generated files are machine-regenerated, not hand-edited. Docs. No regression. CI at this tip. 20 check-runs: all Scope. 6 paths / +222−17 exactly as declared: |
Written-by: FlyBot Dev-3
Fixes #3203
Owner: Dev-3
Bot: Dev-3
Claim-Id: 573b9f003dce4fdbb98af16a79bf8048
Tier: T2 (
core/src/host/meetings.js+ its test)Reviewer: Reviewer
无 UI 面 — 改动只在 host 侧的会议记录与摘要文本、以及归档的
decisions/<date>-<slug>.md;没有浏览器渲染改动,因此没有截图。What changes
meeting.dissentwas stamped once, when a participant first recordeddissentwith text. A later stance change left the withdrawn objection printed as the meeting's dissent while that participant's own row saidagree, and a second dissenter overwrote the first, so only the last objection survived. Both writers — the meeting view and the archived decision file — now read the standing dissent back from the participants' current positions: a withdrawn objection is gone, every participant still dissenting is on the record under their own name, and adecidewithout an explicitdissentrecomputes the record before writing it. The stored singledissentfollows the first objection that still stands; an explicitdecideoverride is printed beside the standing ones and an empty text is still refused.Diff:
core/src/host/meetings.js+48/−7,core/test/meetings.test.js+58,docs/subsystems/core-host.md+9/−3,changelog.d/3203-standing-dissent.fixed.mdnew;patches/ds-bot/files/**regenerated bynode scripts/ds-bot-patches.mjs generate(never hand-edited).Red → green
Red retaken on live main
c0e3a586bf6fb7f7796662a3f200ec34ad7b4d08with only the new tests in the tree and the source unchanged — twice, same shape:Green at the tip
03e10c95c623f3c9ecb5a7990634871eb0a5938c, twice, same shape:Ran
cd core && TZ=UTC TMPDIR=/tmp node --import ./test/harness-resolve.mjs --test test/meetings.test.js— 18/18, twicenpm run lint(core) — 605 files, 97 rules, clean; it ends witharch-docs: OKnode scripts/build-client.mjs --check— ok (nocore/src/client/**change)node scripts/ds-bot-patches.mjs generate/check/canonical—ok 10 patches apply cleanly in order,ok core/ equals ds-bot/ + patches/ds-bot/,ok patches/ds-bot/ is what generate writesnpm test(core, full suite) — 3357 tests, 3355 pass, 2 fail, both unrelated to this change:bench-preflight.test.js"bench.sh shows a failed pnpm install and leaves no half-built profile" (this box keepspnpmin/usr/bin, so the fixture's PATH drops/usr/binandmkdirdisappears) andconnectors.test.jsFeishu connector, phase 2: a message in Feishu starts a turn here (inbound over the long connection) #1266 (timing flake; that file alone is 37/37, twice)Not run
core/dev/smoke.mjs) — not in this change's scope list; the touched path is the meetings record writer, covered by the full core suite above.Checkpoint
{ "pr": 3236, "claim": "Dev-3", "issue": 3203, "summary": "A meeting's dissent was written once and never recomputed: a withdrawn objection stayed on the record and a second dissenter replaced the first. The view and the archived decision now read the dissent back from the participants' current positions, so only standing objections appear, each under its own author. The stored single dissent follows the first objection that stands, and an explicit decide override still prints beside it. Tests hold the withdrawal, two dissenters and the override.", "files": ["core/src/host/meetings.js", "core/test/meetings.test.js", "docs/subsystems/core-host.md", "changelog.d/3203-standing-dissent.fixed.md", "patches/ds-bot/files/src/host/meetings.js", "patches/ds-bot/files/test/meetings.test.js"], "checks": {"ran": "cd core && node --import ./test/harness-resolve.mjs --test test/meetings.test.js; npm run lint; node scripts/ds-bot-patches.mjs check", "result": "green", "at": "03e10c95c623f3c9ecb5a7990634871eb0a5938c"}, "next": "none — ready for review" }