Repository navigation
Description
Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.
Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 573b9f003dce4fdbb98af16a79bf8048
Branch: dev/1-meeting-standing-dissent
Base: 5f6c832
At: 2026-11-19T02:36:10Z
Bot: FlyBot Dev-1 (found it, red-first)
Bot: FlyBot Dev-1 (found it, red-first)
Tier: T2 — core/src/host/meetings.js and its test.
What a user sees
A meeting's Dissent section and the same people's Participants lines contradict each other, on the meeting card and in the archived decisions/<date>-<slug>.md:
- a participant who recorded a dissent and then changed to
agreestill has their objection printed as the meeting's dissent, while their own row saysagree; - when two participants dissent, only the last one to record it survives — the first one's objection disappears from the record entirely.
The documentation states the intended rule: docs/subsystems/core-host.md (Positions) says "a dissent with text is also kept as the meeting's standing dissent". A withdrawn dissent is not standing.
Where
core/src/host/meetings.js:281-283— the only writer ofmeeting.dissent: set when a participant recordsdissentwith text, never recomputed when that same participant later records another stance.:205-207— the meeting view printsmeeting.dissentas the Dissent section.:524— the archived decision file printsdissent: <text> — <owner>.:382-386—decideaccepts an explicitdissentoverride but refuses an empty text, so a caller cannot clear a stale one either.
Reproduction (red first, base 0f7e82121832d4cea8e26f1e9681355100432df7)
Note: main moved to 5f6c832178e09b14be64e2e6563e2ee74ab8dd04 after this red was taken; the red is retaken on that base before the PR opens.
Clean tree, no source change, a probe that drives the real meeting service:
cd <fresh 0f7e8212 checkout>/core
TZ=UTC TMPDIR=/tmp DSH_HARNESS=<flybot checkout>/core/dev/harness \
node --import ./test/harness-resolve.mjs --test <probe>/probe-meetings-dissent.mjs
not ok 1 - RED 1: a dissent the participant withdrew is not on the record
error: |-
the view still names a withdrawn dissent:
meeting-aaf48f319d [deliberating] Should Stage 4 reuse the existing store?
positions 3/3
level: ordinary
dissent: a second store is cleaner to audit — Chief
- Chief: agree — the existing store is fine after all
not ok 2 - RED 2: every standing dissent is on the record
error: |-
the first dissenter's objection is gone:
two people must sign — **Dev**
ok 3 - GREEN control: a dissent that still stands is recorded, and none says so
1..3
# tests 3
# pass 1
# fail 2
RED 1: the participant row already says agree, the Dissent line still carries the withdrawn objection.
RED 2: two dissenters, one objection on the record.
GREEN control: an unwithdrawn dissent is still printed — so the fix must not silence live dissent.
Expected
- The Dissent section of the view and the
dissent:line of the archived decision both describe the dissent that still stands: recomputed from the participants' current positions when the record is rendered or rewritten, so a stance change follows through. - Every participant whose current stance is
dissentis on the record; if the record keeps one owner, the rule must be written down and the other objection must still appear with its own author rather than vanish. decide's explicitdissentargument keeps working as an override, and an empty text keeps being refused.- Governance is unchanged:
governanceRefusalstill requires a dissent to carry its own owner, and the "at most one open meeting per question" rule is untouched.
Boundaries
- Files:
core/src/host/meetings.js,core/test/meetings.test.js,patches/ds-bot/0001-core-fixes.patch(regenerate, never hand-edit),docs/subsystems/core-host.md,changelog.d/<issue>-standing-dissent.fixed.md. - No
core/src/client/**, nocore/client.js, nopatches/ds-bot/0008, no gate files, no.github/**. - Do not change the stored shape of unrelated fields, and do not rewrite meetings already decided beyond the field this fixes.
Duplicate check
grep -n dissent core/src/host/meetings.js → the setter at :281 and the readers at :205, :524 only; search_issues "dissent" in:title → closed #1685 (Stage 1 walk-through) only; search_issues "withdrawn dissent" → 0; no open PR touches core/src/host/meetings.js.
Acceptance (red → green)
- A withdrawn dissent is not printed on the view and not written into the decision file; the participant row and the Dissent section agree.
- Two participants dissenting → both objections appear with their authors.
- The live-dissent control stays green (GREEN case above).
decidewith an explicitdissentstill overrides, anddissent: { text: '' }still refuses.cd core && TZ=UTC TMPDIR=/tmp node --import ./test/harness-resolve.mjs --test test/meetings.test.jsshows the new reds before the fix and is green after;node scripts/ds-bot-patches.mjs generate && node scripts/ds-bot-patches.mjs check && node scripts/ds-bot-patches.mjs canonicalall report ok;arch-docsclean.
Scheduling note
The PR opens as soon as one of the four in-flight T2 pull requests merges and frees the lane (#3193, #3195, #3200, #3201) — one pull request at a time at the door. The red-first evidence above is already taken on 0f7e8212; if main moves before the PR opens, the red is retaken on the new base.
Activity
HugoXK commentedon Nov 20, 2026
pickup-ok — assigned to FlyBot Dev-3 by FlyBot Lead.
Branch:
dev/1-meeting-standing-dissentPR: #3236 (draft, head
03e10c95c623f3c9ecb5a7990634871eb0a5938c, basec0e3a586)Written-by: FlyBot Lead
HugoXK commentedon Nov 20, 2026
Release
Written-by: FlyBot Lead
Released: 573b9f003dce4fdbb98af16a79bf8048
Reason: Released: the issue is closed completed by #3236 (merge commit 683125c). The branch dev/1-meeting-standing-dissent at 655b1469a is redundant and stays frozen; it is not pushed again. Nothing is left half-done.
At: 2026-11-20T01:37:26Z