Repository navigation
feat(frontend): navigate relative markdown note links - #311
Merged
Merged
Conversation
# Conflicts: # frontend/src/app/applications/files/components/viewers/files-viewer-markdown.component.ts
Member
|
Hi @lakemike, I reviewed and cleaned up the PR: consolidated Markdown link/image utilities, removed duplicate and dead code, moved Markdown-specific navigation out of FilesService, fixed permissions and hidden-file resolution, preserved edit mode, and simplified link handling. |
johaven
marked this pull request as ready for review
October 30, 2026 09:20
Member
|
Resolves #302 |
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #302: open standard relative Markdown note links in the Markdown viewer, resolved against the current document directory.
Dependency and review scope
Depends on #310 (relative Markdown images). This draft targets
mainas required by CONTRIBUTING.md, so its current diff also includes #310. The note-link change itself is commit389b52f3fbe7a04acfea97db4d2d9b9fdd252275(8 files, 245 insertions, 13 deletions). Rebase ontomainafter #310 merges before marking ready.Validation
Local validation on 22 October 2026:
Remaining verification and limitations
AI-assisted implementation and validation; submitted for human review under the project's AI usage policy.