Skip to content

fix(support-bot): keep the member role when the API can't be reached #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ugcodrr wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(support-bot): keep the member role when the API can't be reached #1097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fc06ab
fix(support-bot): keep the member role when the API can't be reached
ugcodrr Nov 2, 2026
344b168
fix(api-client): return null from getUser when the user isn't verified
ugcodrr Nov 2, 2026
3cc4368
chore(repo): sync PR 1097 with main and tracked public assets
ugcodrr Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/discord-bot/src/lib/command.listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class CommandListener extends AbstractCommandListener {
guild: interaction.getGuildId() ?? null,
});

const user = await this.apiService.getUser(id);
const user = await this.apiService.getUser(id).catch(() => null);

Sentry.setUser({
id,
Expand Down
2 changes: 1 addition & 1 deletion apps/support-bot/src/lib/command.listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class CommandListener extends AbstractCommandListener {
parentData
);

const user = await this.apiService.getUser(id);
const user = await this.apiService.getUser(id).catch(() => null);

const context = new CommandContext(this, interaction, data);
context.setUser(user);
Expand Down
5 changes: 4 additions & 1 deletion packages/api-client/src/api.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,10 @@ export class ApiService {
public getUser(tag: string) {
return this.request<GetUserResponse>("/user", { tag })
.then((data) => data.user ?? null)
.catch(() => null);
.catch((err) => {
if (axios.isAxiosError(err) && (!err.response || err.response.status >= 500)) throw err;
return null;
});
}

public updateUser(tag: string, update: UpdateUser) {
Expand Down
Loading