Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 30, 2026
ugcodrr
force-pushed
the
chore/sentry-11
branch
from
October 31, 2026 21:37
489edf6 to
cc356e2
Compare
ugcodrr
force-pushed
the
chore/sentry-crons
branch
from
October 31, 2026 21:37
930ab1a to
669ecfa
Compare
Member
Author
|
Closing this, since it only tells us whether the limiter ran, not whether it trimmed the right keys (it wouldn't have caught what #1003 fixes). A separate Sentry project and config key for that is more setup than it's worth, and Redis memory already shows if the limiter stops. #1057 is on #1054 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Nothing told us when the leaderboard limiter failed or stopped running, since it runs on its own every 10 minutes.
Testing: with
sentry.scriptsDsnset,pnpm scripts limit-redisshows up in Sentry's Crons asleaderboard-limitingand checks in every 10 minutes.In Sentry: create a "scripts" project and put its DSN in
config.jsassentry.scriptsDsn.Stacked on #1054.
Merge after #1003, which it conflicts with in
apps/scripts/package.jsonand the lockfile.