Repository navigation
Preserve authored iframe src during remote document navigation - #899
Merged
Merged
Conversation
wieslawsoltes
added this pull request to stack #902
September 21, 2026 07:36
wieslawsoltes
changed the title
This was referenced Sep 21, 2026
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #896. Loading a relative iframe source silently rewrote
getAttribute("src")to the resolved absolute URL, breaking authored markup and the existing beforeunload lifecycle gate. Preserve the authored value while keeping a separate resolved request/committed-origin URL for prefetch, navigation and security decisions.Part 1 of the native GitHub stack #902: #899 → #900 → #901. Validate the top PR against the complete iframe lifecycle gate before merging the stack. The baseline reproduction exists on clean merged main
99cf2f86; full top-branch evidence is indocs/validation/iframe-url-history-896-898.md.Stack created with GitHub Stacks CLI • Give Feedback 💬