Skip to content

Collection of minor fixes and adjustments - #48

Merged
lixfel merged 1 commit into
masterfrom
minor-fixes
Nov 7, 2026
Merged

lixfel merged 1 commit into
masterfrom
minor-fixes

Conversation

@lixfel

@lixfel lixfel commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator
  • Refinement frequently miscalibrates although it has a higher precision ceiling, therefore change default to false
  • When testing with Spinnaker camera setting pixel format failed for me once critically, has worked ever since, but I wouldn't recommend failing each time, just warning about it
  • valgrind complained about aligned_alloc wanting aligned sizes as well -> align size

@lixfel
lixfel requested a review from guyfleeman November 7, 2026 15:26
@lixfel lixfel self-assigned this Nov 7, 2026
@guyfleeman

Copy link
Copy Markdown
Contributor

Does that pixel format fail just once on startup?

@lixfel

lixfel commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator Author

It crashed me once, I have changed it to a warning, has worked ever since, have some starts later no longer seen the warning, so Idk what internal state was problematic.

@guyfleeman

Copy link
Copy Markdown
Contributor

I've seen other startup race conditions on clearing persistent configs as well. Those always clear for me on re-try. I wonder if that's happening here too. Did log and crash you out or just segfault?

@lixfel

lixfel commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator Author

Log and crash, segfault I had too with other configurations, but that was more OpenCL related and resolved with your changes.

@lixfel
lixfel merged commit f126ad6 into master Nov 7, 2026
3 checks passed
@lixfel
lixfel deleted the minor-fixes branch November 7, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants