Repository navigation
Collection of minor fixes and adjustments - #48
Merged
Merged
Conversation
lixfel
commented
Nov 7, 2026
Collaborator
- Refinement frequently miscalibrates although it has a higher precision ceiling, therefore change default to false
- When testing with Spinnaker camera setting pixel format failed for me once critically, has worked ever since, but I wouldn't recommend failing each time, just warning about it
- valgrind complained about aligned_alloc wanting aligned sizes as well -> align size
Contributor
|
Does that pixel format fail just once on startup? |
Collaborator
Author
|
It crashed me once, I have changed it to a warning, has worked ever since, have some starts later no longer seen the warning, so Idk what internal state was problematic. |
Contributor
|
I've seen other startup race conditions on clearing persistent configs as well. Those always clear for me on re-try. I wonder if that's happening here too. Did log and crash you out or just segfault? |
Collaborator
Author
|
Log and crash, segfault I had too with other configurations, but that was more OpenCL related and resolved with your changes. |
guyfleeman
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.