Repository navigation
perf: rgit context skips language servers; gopls stays up 2h - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rgit context dialled a language server per changed file (vtsls and marksman spawn fresh per call), costing ~0.5-1.8s per call in larger repos; it now skips the LSP cross-check (diff.Options.SkipCrossCheck). rgit diff and rgit commit still verify. context no longer prints W ts-only or cross-check mismatch lines (help, USAGE, CODES, CHANGELOG updated). Measured on a mortar-size clone with 10 edited files, 5 runs: median 568 ms -> 234 ms. gopls -listen.timeout 10m -> 2h: its daemon reload cost ~80s CPU after every 10 idle minutes and the 2s query deadline expired during it. The shared gopls socket was checked and does not mix workspaces (each connection announces its own root). Also: SECURITY.md reporting/disclosure/timeline text. Tests: a live mock LSP socket proves context makes zero connections while diff does. Gate green.