Repository navigation
Raise the PostgreSQL floor to 12 and add GitHub Actions CI with update testing - #4
Draft
jnasbyupgrade wants to merge 11 commits into
Draft
jnasbyupgrade wants to merge 11 commits into
jnasbyupgrade wants to merge 11 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
jnasbyupgrade
added this pull request to stack #5
October 25, 2026 19:13
jnasbyupgrade
marked this pull request as draft
October 25, 2026 19:16
jnasbyupgrade
force-pushed
the
ci-workflow
branch
from
October 25, 2026 19:27
fa35b1d to
e2486ed
Compare
jnasbyupgrade
force-pushed
the
ci-workflow
branch
from
October 25, 2026 19:38
e2486ed to
789b597
Compare
jnasbyupgrade
removed this pull request from stack #5
October 25, 2026 19:47
Adds `.github/workflows/ci.yml`: a changes job that skips the test matrix on docs-only pushes and derives the supported PostgreSQL major list from one pair of constants, a per-major test job in the `pgxn/pgxn-tools` container that runs `make verify-results`, and a single `all-checks-passed` job for branch protection. Removes the Travis configuration (`.travis.yml`, `pg-travis-test.sh`), which tested only PostgreSQL 9.5 and 9.6. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Matches the final trunklet CI workflow: supported range is PostgreSQL 9.5 through 18, with 9.6 and 9.5 listed explicitly because `seq` can't express them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jnasbyupgrade
force-pushed
the
ci-workflow
branch
from
October 25, 2026 19:47
789b597 to
7f24f9b
Compare
jnasbyupgrade
added this pull request to stack #7
October 25, 2026 19:47
extension_drop installs cat_tools >= 0.2.1, which now resolves to cat_tools 0.3.0; that release requires PostgreSQL 12 and fails to install on older majors. Set the PostgreSQL build prereq to 12.0.0, make the CI matrix a plain range from NEWEST down to FLOOR=12, and drop the test setup code that only ran before PostgreSQL 10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 25, 2026
jnasbyupgrade
removed this pull request from stack #7
October 25, 2026 20:10
jnasbyupgrade
added this pull request to stack #9
October 25, 2026 20:10
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`make test-update` (TEST_LOAD_SOURCE=update) runs the same suite with the same expected output, but pg_temp._create() installs 0.2.0 and runs ALTER EXTENSION UPDATE instead of installing the current version. It creates extension_drop first, since 0.2.0 did not require it. CI runs it as a second step in each test job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the supported PostgreSQL floor to 12 and replaces Travis with GitHub Actions CI. On every supported major, CI tests both a fresh install and the update from 0.2.0.
The floor is 12 because extension_drop pulls in cat_tools, and cat_tools 0.3.0 and newer declare PostgreSQL 12 as their minimum (on 9.6, creating it fails with
syntax error at or near "ROUTINE"). This PR raises the PostgreSQL build prereq inMETA.in.jsonto 12.0.0, adds aHISTORY.ascentry, and removes thetest/deps.sqlsetup code that only ran before PostgreSQL 10.Update testing
make test-update(make test TEST_LOAD_SOURCE=update) runs the same suite against the same expected output. Instead of installing the current version,pg_temp._create()intest/deps.sqlinstalls 0.2.0 and runsALTER EXTENSION "trunklet-format" UPDATE. It creates extension_drop first, as updating from 0.2.0 requires. The mode reaches the tests as a placeholder GUC (trunklet_format.test_load_mode) throughPGOPTIONS, and_create()fails if the GUC is missing or holds an unknown value. With the function replacement removed fromsql/trunklet-format--0.2.0--stable.sql,make test-updatefails.CI
.github/workflows/ci.ymlhas three jobs:NEWESTandFLOOR.pgxn/pgxn-toolscontainer that runsmake verify-results, thenmake verify-results TEST_LOAD_SOURCE=update.all-checks-passedjob for branch protection.Run 40230691469 passes on PostgreSQL 12 through 18, with both test steps green on each major.
Also removes the Travis configuration (
.travis.yml,pg-travis-test.sh), which tested only PostgreSQL 9.5 and 9.6, along with test comments that referred to Travis or to PostgreSQL 10.🤖 Generated with Claude Code