[jnasbyupgrade]

Adapts trunklet-format to the vendored pgxntool 2.4.0 (merged in #6) so make test actually runs and passes on current PostgreSQL. The old base.mk passed --load-language=plpgsql to pg_regress, which PostgreSQL 13 and later reject, and ignored installcheck errors, so make test exited 0 without running any test. pgxntool 2.4.0 runs the suite and exits non-zero on regressions.

Changes needed in trunklet-format:

• Makefile: removed the local asciidoc rules; base.mk now builds and installs docs itself, and keeping both made make install fail with "will not overwrite just-created".
• test/expected/base_94*.out, base_95*.out, base_961.out: removed; they have no matching test/sql file and fail pgxntool's stale-expected check.
• test/sql/base.sql: every multi-row test input is now read through an ORDER BY on explicit positions, so pgTAP test numbers don't depend on the join order the planner picks. (PostgreSQL 17 joined the threw checks' inputs in the other order.)
• test/load.sql, test/deps.sql, test/sql/{build,reload,search_path}.sql: terse verbosity is set only around the statements that create the extension. extension_drop's install script calls function__arg_types_text() from cat_tools 0.3.0 (which extension_drop pulls in), and that prints a deprecation warning; with verbose output the warning gets a LOCATION: line whose pl_exec.c line number differs between PostgreSQL majors.
• test/expected/*.out: regenerated with make results (the warning is pinned without its LOCATION: line). Output contains no not ok.

make test passes locally on PostgreSQL 12 and 17. The stacked PR #4 adds CI and raises the supported floor to PostgreSQL 12; its run on top of this branch passes on PostgreSQL 12 through 18, for both a fresh install and the update from 0.2.0 (run 40230691469).

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 514f2628-64bc-43f2-bd0b-66a45a422387

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}