Skip to content

Test PGXNTOOL_VERIFY_RESULTS_MODE validation #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnasbyupgrade merged 2 commits into from
Oct 7, 2026
Merged

Test PGXNTOOL_VERIFY_RESULTS_MODE validation #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
629cd30
Test PGXNTOOL_VERIFY_RESULTS_MODE validation
jnasbyupgrade Oct 7, 2026
0fa3ff8
Merge remote-tracking branch 'upstream/master' into pre-2.4.0-verify-…
jnasbyupgrade Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions test/standard/make-test.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
# - verify-results blocks `make results` when tests are failing, lets a
# brand-new test's first expected output through (issue #119), and can be
# disabled. Its own pass/fail logic lives in verify-results-pgtap-script.bats
# - PGXNTOOL_VERIFY_RESULTS_MODE is validated (pgtap/diffs, case-insensitive)

load ../lib/helpers

Expand Down Expand Up @@ -647,6 +648,43 @@ EOF
assert_not_contains "$output" "Cannot run 'make results'"
}

@test "PGXNTOOL_VERIFY_RESULTS_MODE accepts pgtap/diffs case-insensitively" {
run make print-PGXNTOOL_VERIFY_RESULTS_MODE
assert_success
assert_contains "$output" 'set to "pgtap"'

local value expected
for value in pgtap pgTap PGTAP diffs Diffs DIFFS; do
expected=$(echo "$value" | tr '[:upper:]' '[:lower:]')
run make print-PGXNTOOL_VERIFY_RESULTS_MODE "PGXNTOOL_VERIFY_RESULTS_MODE=$value"
assert_success
assert_contains "$output" "set to \"$expected\""
done
}

@test "PGXNTOOL_VERIFY_RESULTS_MODE rejects invalid values" {
local value
for value in bogus pgtapp "pgtap diffs" ""; do
run make print-PGXNTOOL_VERIFY_RESULTS_MODE "PGXNTOOL_VERIFY_RESULTS_MODE=$value"
assert_failure
assert_contains "$output" "PGXNTOOL_VERIFY_RESULTS_MODE must be one of: pgtap diffs; got \"$value\""
done
}

@test "mixed-case PGXNTOOL_VERIFY_RESULTS_MODE selects the matching verify-results recipe" {
# The pgtap recipe invokes verify-results-pgtap.sh; the diffs recipe is an
# inline regression.diffs check carrying the block message.
run make -n verify-results PGXNTOOL_VERIFY_RESULTS_MODE=pgTap 2>&1
assert_success
assert_contains "$output" "verify-results-pgtap.sh"
assert_not_contains "$output" "Cannot run 'make results'"

run make -n verify-results PGXNTOOL_VERIFY_RESULTS_MODE=DIFFS 2>&1
assert_success
assert_contains "$output" "Cannot run 'make results'"
assert_not_contains "$output" "verify-results-pgtap.sh"
}

@test "make results updates expected output" {
skip_if_no_postgres

Expand Down
Loading