Repository navigation
Test PGXNTOOL_VERIFY_RESULTS_MODE validation - #99
Merged
jnasbyupgrade merged 2 commits intoOct 7, 2026
Merged
jnasbyupgrade merged 2 commits into
jnasbyupgrade merged 2 commits into
Conversation
Add tests for pgxntool commit 7a7e9fb (Postgres-Extensions/pgxntool#132), which validates `PGXNTOOL_VERIFY_RESULTS_MODE`: - Accepts `pgtap`/`diffs` case-insensitively - Rejects anything else, including empty, with a parse-time error New `make-test.bats` cases: - Default and mixed-case values normalize correctly via `print-` - Invalid, multi-word and empty values fail with the expected message - Mixed-case values select the matching `verify-results` recipe (`make -n`) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Oct 7, 2026
`PGXNTOOL_VERIFY_RESULTS_MODE` is now validated: it accepts `pgtap` or `diffs`, case-insensitively, and any other value is a parse-time `make` error. Before this, any value other than exactly `pgtap` (for example the typo `pgTap`) silently selected `diffs` mode and weakened the `make results` safeguard. Paired pgxntool-test PR: Postgres-Extensions/pgxntool-test#99 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for Postgres-Extensions/pgxntool#132, which validates
PGXNTOOL_VERIFY_RESULTS_MODE. The variable now acceptspgtapordiffscase-insensitively, and any other value is a parse-time error.Merge Postgres-Extensions/pgxntool#132 first. These tests check behavior that doesn't exist on pgxntool master yet. If this PR lands first, CI fails for every unpaired pgxntool-test PR until #132 merges. See CLAUDE.md, "Merge Order for Paired PRs".
New
test/standard/make-test.batscasesprint-PGXNTOOL_VERIFY_RESULTS_MODEshowspgtap.pgtap,pgTap,PGTAP,diffs,DiffsandDIFFSeach print the lowercase value.bogus,pgtapp,pgtap diffsand an empty value each fail withPGXNTOOL_VERIFY_RESULTS_MODE must be one of: pgtap diffs; got "<value>".make -n verify-resultswithpgTapshows theverify-results-pgtap.shrecipe. WithDIFFSit shows the inline regression.diffs check. This guards against the original bug, where a mixed-case value silently selected the diffs recipe.All three cases run at the
print-/make -nlayer and don't need a database.🤖 Generated with Claude Code