Repository navigation
fix: improve reader progress, navigation and host-owned panels - #6
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 10, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e76d6849e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EPUB progress now uses a document-wide content index instead of weighting every spine item equally. SVG-wrapped raster covers render, next/previous and slider navigation agree, and chapter preparation keeps the committed page and progress visible. Adjacent chapter prefetch, bounded layout caching, cancellation, and retry reduce disruptive transitions.
Reader controls are flush overlays with tap-to-toggle behavior, a standard back button, compact progress spacing, and distinct docked panels. Hosts can provide compact panel routes and reuse their own sheet shell while the reader owns panel lifecycle. The current locator contract uses spine indices and content offsets; synthetic CFI compatibility members were removed.
Validation
docs/reader-navigation-validation.md.Integration
The client PR pins this reader commit and supplies the shared Papyrus sheet shell. This is a pre-release API cleanup: no migration shims or version bump are included. Private SQL and PDF validation inputs and local screenshots remain outside committed fixtures.
Review follow-up
Preserve non-wrapper SVG artwork in sanitized HTML and embed its local image resources without flattening mixed/vector content. Wide panels now follow the actual custom toolbar height, including changes while open. Regression tests cover both fixes. The requested overlay/pagination behavior remains unchanged and is now explicit in AGENTS.md.