Repository navigation
fix: integrate reader sheets, PDF imports and current data contracts - #46
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…egration-and-pdf-import
…mport' into fix/reader-integration-and-pdf-import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the improved EPUB/PDF reader with the client's shared bottom-sheet shell, motion-aware opening loader, and current position persistence. The reader dependency is pinned to the committed revision in PapyrusReader/reader#6.
Complete browser PDF import and OPDS acquisition support with shared PDF metadata extraction, worker hashing/storage, and retry-safe byte handling. Remove pre-release compatibility envelopes, migrations, aliases and tracking-version fallbacks; producers and consumers now use the current contract together. Server cleanup: PapyrusReader/server#14.
Testing
docs/pdf-import-validation.md, the reader validation report andapp/integration_test/reader_real_books_test.dartfor reproduction and target limitations. Authenticated live synchronization and a fresh native-device PDF picker session were not run.UI evidence
Desktop Chrome and iOS simulator screenshots were inspected locally. Evidence remains in ignored build directories, including
app/build/reader-sheets-validation/andapp/build/pdf-validation/; private book content and local test artifacts are not published in this PR.Compatibility and migration
Pre-release cleanup intentionally drops old metadata envelope/locator recovery, model aliases and old tracking-contract fallbacks. Current metadata, offline retries and account isolation remain covered. No database schema migration, data reset or version bump is included.
Notes
Merge the reader and server PRs before the coordinating workspace PR. PDF cover thumbnail generation and import password entry remain outside this change. Public Gutenberg fixtures are in the reader repository; private validation books are excluded.
Checklist