Skip to content

fix: integrate reader sheets, PDF imports and current data contracts - #46

Merged
Eoic merged 6 commits into
developmentfrom
fix/reader-integration-and-pdf-import
Oct 10, 2026
Merged

Eoic merged 6 commits into
developmentfrom
fix/reader-integration-and-pdf-import

Conversation

@Eoic

@Eoic Eoic commented Oct 10, 2026

Copy link
Copy Markdown
Member

Summary

Use the improved EPUB/PDF reader with the client's shared bottom-sheet shell, motion-aware opening loader, and current position persistence. The reader dependency is pinned to the committed revision in PapyrusReader/reader#6.

Complete browser PDF import and OPDS acquisition support with shared PDF metadata extraction, worker hashing/storage, and retry-safe byte handling. Remove pre-release compatibility envelopes, migrations, aliases and tracking-version fallbacks; producers and consumers now use the current contract together. Server cleanup: PapyrusReader/server#14.

Testing

  • Full client suite: 1,620 passed, 19 skipped. Final media, acquisition and tracking changes: 45 focused tests passed.
  • Locked dependency resolution without the local reader override and 23 reader/page/PDF tests passed against the pushed reader revision.
  • Client formatting, analysis, bootstrap checks and production web build passed.
  • Actual client iOS simulator sessions passed real-book EPUB navigation, controls, persistence and PDF controls. Desktop Chrome PDF import, rendering, seeking and restart/resume passed with the 883-page MIT SICP PDF.
  • See docs/pdf-import-validation.md, the reader validation report and app/integration_test/reader_real_books_test.dart for reproduction and target limitations. Authenticated live synchronization and a fresh native-device PDF picker session were not run.

UI evidence

Desktop Chrome and iOS simulator screenshots were inspected locally. Evidence remains in ignored build directories, including app/build/reader-sheets-validation/ and app/build/pdf-validation/; private book content and local test artifacts are not published in this PR.

Compatibility and migration

Pre-release cleanup intentionally drops old metadata envelope/locator recovery, model aliases and old tracking-contract fallbacks. Current metadata, offline retries and account isolation remain covered. No database schema migration, data reset or version bump is included.

Notes

Merge the reader and server PRs before the coordinating workspace PR. PDF cover thumbnail generation and import password entry remain outside this change. Public Gutenberg fixtures are in the reader repository; private validation books are excluded.

Checklist

  • The branch, commits, and pull request title follow the repository conventions.
  • The change is complete and limited to the agreed scope.
  • Relevant tests have been added or updated.
  • Formatting, analysis, and tests pass.
  • Documentation, UI evidence, and migration notes are included where relevant.
  • No credentials, personal data, copyrighted fixtures, or unrelated generated files are included.
  • The branch is up to date with its target branch.

Copilot AI balanced review requested due to automatic review settings October 10, 2026 18:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T18:27:33.403484Z 5677ba9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic Eoic self-assigned this Oct 10, 2026
@Eoic
Eoic merged commit 4015333 into development Oct 10, 2026
4 checks passed
@Eoic
Eoic deleted the fix/reader-integration-and-pdf-import branch October 13, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants