Skip to content

fix(devices): lock DPI light brightness in modes that ignore it #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oenderg wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(devices): lock DPI light brightness in modes that ignore it #1495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/features/devices/cards/AdvancedCards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,9 @@ export function DpiLightingCard({ snapshot }: { snapshot: ControlSnapshot }): Re
const speedMax = hint?.speed.at(-1) ?? profile!.dpiLighting.speed.max;
const locale = snapshot.preferences.locale;
const lightMode = status.dpiLedMode ?? 0;
// Some mice only take a brightness in certain modes (ATK R1: steady only).
const brightnessModes: readonly number[] | undefined = hint?.brightnessModes;
const brightnessLocked = lightMode === 0 || (brightnessModes != null && !brightnessModes.includes(lightMode));

const staged = snapshot.pending.keys.some((key) => key.startsWith("teevolution-dpi-light-") || key === "dpi-light-sleep");
return (
Expand Down Expand Up @@ -684,7 +687,7 @@ export function DpiLightingCard({ snapshot }: { snapshot: ControlSnapshot }): Re
max={brightnessMax}
step={1}
value={status.dpiLedBrightness ?? brightnessMin}
disabled={lightMode === 0 || status.dpiLedBrightness == null}
disabled={brightnessLocked || status.dpiLedBrightness == null}
style={{
"--fill": `${((status.dpiLedBrightness ?? brightnessMin) - brightnessMin)
/ Math.max(1, brightnessMax - brightnessMin) * 100}%`,
Expand Down
Loading