Repository navigation
Conversation
The VXE R1 Pro and R1 Pro Max take a DPI indicator brightness only while the effect is steady. The slider stayed enabled while breathing, so a change appeared to apply and then snapped back on the next read. Disable the slider when the driver's ui.dpiLighting.brightnessModes hint is present and does not include the current mode. Devices that do not send the hint behave as before.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the VXE R1 Pro and R1 Pro Max, the DPI indicator's brightness slider stayed
enabled while the effect was Breathing. The driver leaves brightness untouched
in that mode (as ATK HUB does), so a change appeared to apply and then snapped
back on the next read.
Change
DpiLightingCardnow disables the brightness slider when the driver'sui.dpiLighting.brightnessModeshint is present and does not include thecurrent mode. Devices that do not send the hint behave as before.
No strings, settings or controls are added or removed.
Depends on
OpenMouse-Project/mouse-protocol#306, which adds the
brightnessModeshint.This is a draft until
@openmouse/protocolis bumped to a release thatincludes it; it does not type-check against the currently published package.
Testing
npm run checkpasses with the protocol build fromfeat(atk): support the VXE R1 Pro over the 1K dongle mouse-protocol#306 installed locally (build, bundle size,
658 of 658 tests).