Repository navigation
fix: align async read disposal with synchronous reads - #115
Merged
Merged
Conversation
AGiorgetti
marked this pull request as ready for review
November 12, 2026 15:34
Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com> Co-authored-by: Codex (OpenAI) <codex@openai.com>
AGiorgetti
force-pushed
the
fix/109-async-disposal
branch
from
November 17, 2026 15:13
5959536 to
3f69d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #109.
Rebased onto
developafter #116. #116 already enforces per-batch disposal checks in default mode, but the legacy whole-read translation path bypasses those guards. This change is still needed to close that gap.WrapAsyncApplicationExceptionssettings.Breaking change
An active legacy-mode async read now reports
ObjectDisposedExceptionthrough its existing error path at the next cursor advance after disposal. The wrapping opt-out does not disable lifetime checks. Default mode retains #116 behavior. Callers needing prompt interruption should cancel and await active reads before disposing.Verification
Current rebased head:
3f69d30fe8bf51870d3ced29952d175bd3e20b8e.Co-authored-by: Alessandro Giorgetti alessandro.giorgetti@live.com
Co-authored-by: Codex (OpenAI) codex@openai.com