You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prefer MongoDB write categories and command codes over broad exception-message substring matching. Use structured key patterns when available; otherwise match complete index tokens in legacy duplicate-key messages. Preserve checkpoint retries, duplicate commit detection, and stream concurrency handling in both sync and async paths. Add representative response/message regressions and a changelog note. No production dependency or schema change. Approved breaking API cleanup: remove the unused MongoCommitIndexes.CheckpointNumberMMApV1 and CheckpointNumberWiredTiger public constants; migration guidance is in Changelog.md.
Verification
Public-constant removal is commit d1ae29e48342f510ad626f25e501ca4aadd80639. No source references remain. Exact-head CI run 44131308641 passed Ubuntu and Windows builds and all seven full-suite jobs, each with 2,092 passed, zero failed and zero skipped: .NET 8/9/10 with Driver 3.0.0 and 3.13.0 on MongoDB 7.0.45, plus .NET 10 / Driver 3.13.0 on MongoDB 9.0.4. No local build/test or .NET Framework 4.7.2 test execution was performed for this head. Earlier results below predate this removal.
Rebased onto develop after fix: align async read disposal with synchronous reads #115/Align async Mongo exception boundaries with synchronous reads (#108) #116 at head 114a3bbaade5925602ea563c6f140987cc7b7c70.
All seven full-suite jobs passed 2,092 tests each, with zero failures or skips: .NET 8/9/10 with Driver 3.0.0 and 3.13.0 on MongoDB 7.0.45, plus .NET 10 / Driver 3.13.0 on MongoDB 9.0.4.
Independent review found no blocking issue; sync/async commit classification remains necessary and the merged read/observer behavior is unchanged.
Current head was not tested locally: submodule clone was blocked by a connection reset. .NET Framework 4.7.2 execution was not repeated for this head.
Earlier pre-rebase verification included 31 focused tests across eight framework/driver lanes; those historical results are not current-head verification.
Co-authored by Alessandro Giorgetti and Codex (OpenAI).
Document the approved public API removal and migration guidance.
Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com>
Co-authored-by: Codex (OpenAI) <codex@openai.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
A null MongoWriteException.WriteError can cause a NullReferenceException in both commit paths, masking the original write-concern failure and bypassing storage-error translation.
Hardens duplicate-key classification in the MongoDB persistence adapter for #92, preserving distinct checkpoint retry, duplicate-commit, and concurrency handling across synchronous and asynchronous writes.
Changes:
Adds a shared classifier that prioritizes driver categories, error codes, and structured key patterns, with an exact-token legacy message fallback.
Adds regression cases for structured errors and legacy messages.
Removes two obsolete public constants and documents migration guidance.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The classifier can mistake an index clause embedded in a duplicate-key value for the checkpoint index, causing both commit paths to retry collisions that changing the checkpoint cannot resolve.
The structured cases all omit index information from the message, so they still pass if message parsing takes precedence or an unknown pattern incorrectly falls back to _id_. Add conflicting metadata/message cases, including an unknown compound pattern containing _id, to protect both commit paths from incorrectly retrying a concurrency failure as a checkpoint collision.
Bound legacy index parsing to the first duplicate-value delimiter. Cover embedded index clauses and authoritative conflicting key patterns.
Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com>
Co-authored-by: Codex (OpenAI) <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #92.
Prefer MongoDB write categories and command codes over broad exception-message substring matching. Use structured key patterns when available; otherwise match complete index tokens in legacy duplicate-key messages. Preserve checkpoint retries, duplicate commit detection, and stream concurrency handling in both sync and async paths. Add representative response/message regressions and a changelog note. No production dependency or schema change. Approved breaking API cleanup: remove the unused MongoCommitIndexes.CheckpointNumberMMApV1 and CheckpointNumberWiredTiger public constants; migration guidance is in Changelog.md.
Verification
d1ae29e48342f510ad626f25e501ca4aadd80639. No source references remain. Exact-head CI run 44131308641 passed Ubuntu and Windows builds and all seven full-suite jobs, each with 2,092 passed, zero failed and zero skipped: .NET 8/9/10 with Driver 3.0.0 and 3.13.0 on MongoDB 7.0.45, plus .NET 10 / Driver 3.13.0 on MongoDB 9.0.4. No local build/test or .NET Framework 4.7.2 test execution was performed for this head. Earlier results below predate this removal.Rebased onto develop after fix: align async read disposal with synchronous reads #115/Align async Mongo exception boundaries with synchronous reads (#108) #116 at head
114a3bbaade5925602ea563c6f140987cc7b7c70.Co-authored by Alessandro Giorgetti and Codex (OpenAI).