Repository navigation
Store the request ID on inference logs - #444
Merged
Merged
Conversation
The inference app gives every request an X-Request-ID (#442); the log row now keeps it, so a request seen in a client's error or a log line can be found. Adds a request_id column (migration for existing installs, index built concurrently), sends it from the inference client, returns it with each log, and lets GET /insights/logs filter by it. Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#442 gives every inference request an X-Request-ID, but the stored log row never kept it, so a request seen in a client's error or a log line could not be found in the logs.
SPLITmarker, as in 20260530_pool_first_deployments.sql, so it doesn't block inserts).Rows logged before this keep request_id null.
Tests: the id is stored (and null without one), the insights filter uses it, the client sends the id of the request being logged. Applied with the repo's migration runner twice: the index is built concurrently and valid, and the second run is a no-op. Full suite with the CI ignore list: 3,073 passed.
Follow-up: show the request ID in the Insights log details and add a search box next to the IP filter.