Repository navigation
fix: TV right-to-left rail and keyboard, whole post images, Home repeats, lyrics translation, picture-in-picture and every artist - #1659
Merged
Conversation
…to-left languages
…trols as it starts
…re-in-picture fixes
…ongs and playlists
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data.music.model.Related issue
Closes #1602
Closes #1585
Closes #1565
Closes #1524
Closes #1523
Change type
Validation
./gradlew :app:assembleGithubDebug: passed./gradlew :app:testGithubDebugUnitTest: 4,875 tests, 45 skipped, 0 failures./gradlew ktlintCheck: passed./gradlew :app:compileFossDebugKotlin: passed./gradlew :app:minifyGithubReleaseWithR8: passed;seeds.txtkeepsMusicTrack,MusicArtistandMusicItemTypewith their fieldsNeuroBenchmarkTest: seenRepeat 0.079 to 0.064, nDCG 0.968 to 0.980; Music and Home replay benchmarks unchangedpython3 .github/scripts/nightly_notes.py --check: passedTest device and Android version: Xiaomi phone, HyperOS (Android 16); Android TV emulator (API 36); resizable emulator (API 37)
Screenshots or recordings
Risk and compatibility
No Room schema change.
Network: one extra queue request per multi-artist song, made only on an artist tap and cached for the session.
Picture-in-picture params are pushed again once the video has been laid out, never while the window is entering or open.
Home shows fewer repeats, so pools can run shorter between refreshes.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.