[A-EDev]

Summary

The LAN hello now checks what it reads before using it: nonces must be strict 32-byte base64url (as spec/live.md says), signatures 64-byte strict base64url (else SIGNATURE), the membership check runs before fromHex on the peer's did, and fields and the port are read with their types checked. Before, a non-base64 nonce or a non-string did threw IllegalArgumentException, a 16-byte nonce was accepted and message 2 was signed and sent, and "p":{} threw. LanSync.meet already caught these, so it wasn't user-visible.

Related issue

Change type

• Bug fix
• Feature
• Refactor or maintenance
• Build, packaging, or CI
• Documentation

Validation

• ./gradlew :app:assembleGithubDebug: not run locally, no app code outside sync2 changed; CI builds the APK
• ./gradlew --offline :app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.sync2.*' --tests 'io.github.aedev.flow.sync.*': 160 sync2 and 162 sync tests, 0 failures. New LanLinkTest 3/3; before: expected:<[Unexpected, 0 sent x3]> but was:<[IllegalArgumentException, 0 sent, Unexpected, 1 sent, IllegalArgumentException, 0 sent]>
• ./gradlew --offline ktlintCheck: passed
• I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: not device-tested

Risk and compatibility

LAN only; valid hellos are unchanged.

• The change does not introduce secrets, private data, or unexpected telemetry.
• New user-facing text uses Android string resources.
• Dependency and lockfile changes are intentional and limited to this PR.
• Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
• Breaking changes and upgrade steps are clearly documented.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.