Skip to content

fix: Return 401 instead of 500 when X-Environment-Key is missing #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ash-vd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Return 401 instead of 500 when X-Environment-Key is missing #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/edge_proxy/environments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,11 @@ async def refresh_environment_caches(self):
self.last_updated_at = datetime.now()

def get_flags_response_data(
self, environment_key: str, feature: str | None = None
self, environment_key: str | None, feature: str | None = None
) -> dict[str, Any] | list[dict[str, Any]]:
if not environment_key:
raise FlagsmithUnknownKeyError(environment_key)

is_server_key = environment_key.startswith(SERVER_API_KEY_PREFIX)
if is_server_key:
environment_key = self._get_client_key_from_server_key(environment_key)
Expand Down Expand Up @@ -128,8 +131,11 @@ def get_flags_response_data(
return map_flag_results_to_response_data(flags, feature_types)

def get_identity_response_data(
self, input_data: IdentityWithTraits, environment_key: str
self, input_data: IdentityWithTraits, environment_key: str | None
) -> dict[str, Any]:
if not environment_key:
raise FlagsmithUnknownKeyError(environment_key)

is_server_key = environment_key.startswith(SERVER_API_KEY_PREFIX)
if is_server_key:
environment_key = self._get_client_key_from_server_key(environment_key)
Expand Down
23 changes: 23 additions & 0 deletions tests/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,16 @@ def test_get_flags_unknown_key(
}


def test_get_flags_missing_key(
client: TestClient,
) -> None:
# When
response = client.get("/api/v1/flags")

# Then
assert response.status_code == 401


def test_post_identity_with_traits(
mocked_environment_cache,
environment_1_feature_states_response_list_response_with_segment_override,
Expand Down Expand Up @@ -171,6 +181,19 @@ def test_post_identity__invalid_trait_data__expected_response(
assert response.json()["detail"][-1]["type"] == "string_too_long"


def test_post_identity_missing_key(
client: TestClient,
) -> None:
# When
response = client.post(
"/api/v1/identities/",
content=orjson.dumps({"identifier": "test_identifier"}),
)

# Then
assert response.status_code == 401


def test_get_identities(
mocked_environment_cache,
client: TestClient,
Expand Down