Repository navigation
Conversation
Since Flagsmith#182, get_flags_response_data and get_identity_response_data call environment_key.startswith() before get_environment(), so a request without an X-Environment-Key header raises AttributeError and returns a 500. Up to 2.21.2 the same request got a 401 from get_environment(). Check for a missing key first and raise FlagsmithUnknownKeyError, the same response the environment document endpoint gives.
ash-vd
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #182,
get_flags_response_dataandget_identity_response_datacallenvironment_key.startswith()beforeget_environment(), so a request without anX-Environment-Keyheader raisesAttributeErrorand returns a500. Up to 2.21.2 the same request got a 401 from
get_environment().Check for a missing key first and raise
FlagsmithUnknownKeyError, the same response the environment document endpoint gives.