Repository navigation
fogproject tests: upgrade a real 1.5 database, from stable and dev-branch - #44
Merged
Merged
Conversation
…anch A 1.5 server's schema count lands on a different 1.6 step whenever 1.5 adds one, so the 1.6 updater skips 1.6 steps. The rehearsal job cannot see that, because it builds its start from 1.6's own steps (fogproject GH-2000). The new job runs fogproject's tests/upgrade-from-15-ci.test.sh. It installs the schema with 1.5's own updater and upgrades it with the pull request's, and fails on an update error or a structure that differs from a fresh install. One leg starts from stable, which the field runs. The other starts from dev-branch, where the next 1.5 schema change lands first. A branch without the script skips. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A 1.5 server's schema count lands on a different 1.6 step whenever 1.5 adds one, and the 1.6 updater skips every 1.6 step below that count. On 1.5.10.2518 this skipped
CREATE TABLE fileDeleteQueueand theusers.uNamewidening (FOGProject/fogproject#2000). Therehearsaljob cannot see this, because it builds its starting database from 1.6's own steps.Change
A new
upgrade15job, with two legs:fogproject / upgrade from stablestarts from the 1.5 that the field runs.fogproject / upgrade from dev-branchstarts from where the next 1.5 schema change lands first, so that leg warns before the change ships in a release.Each leg runs fogproject's
tests/upgrade-from-15-ci.test.sh. The script installs the schema with 1.5's own updater, then upgrades it with the pull request's real updater. Both run under Apache in aphp:7.4container. The script fails on an update error, a short schema version, a shape difference from the manifest, or a lostAUTO_INCREMENT. The 1.5 branch is always fetched from FOGProject/fogproject, also for a fork's PR. A branch without the script skips the job.The fogproject side is FOGProject/fogproject#2007. Until that merges, the job skips on every fogproject branch.
Ruleset
Neither context is required yet. The plan is to require
fogproject / upgrade from stableonce it has run green on working-1.6. The dev-branch leg stays advisory, because a dev-branch change is not the 1.6 PR's fault.🤖 Generated with Claude Code