Repository navigation
Conversation
edge-exchange-plugins no longer ships a transfer swap plugin, so the sort rule that put its quotes ahead of the preferred provider is dead.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
Asana task
sortQuotesput any quote from a swap plugin with the idtransferahead of every other quote, including the user's preferred provider. edge-exchange-plugins is removing itstransferplugin (same-asset moves between two wallets are no longer offered as a swap). This rule now has nothing left to rank, and this PR drops it. Plugin-type preference (DEX vs CEX) and the rest of the sort are unchanged.Companion PRs: EdgeApp/edge-exchange-plugins#516 removes the plugin, and EdgeApp/edge-react-gui#6292 stops loading it and blocks same-asset pairs in the swap pickers.