Skip to content

Add delegated expert review protocol - #677

Merged
yuecideng merged 2 commits into
mainfrom
codex/review-expert-protocol-pr
Sep 23, 2026
Merged

yuecideng merged 2 commits into
mainfrom
codex/review-expert-protocol-pr

Conversation

@yuecideng

Copy link
Copy Markdown
Contributor

Description

This PR upgrades $review-pr from a single reviewer using informal role perspectives to an explicit expert-review protocol. It adds stable role IDs, bounded role selection, subagent task packets and result contracts, lead verification and deduplication, transparent single-agent fallback, and a required role-coverage table.

The protocol preserves read-only review and evidence requirements. It uses independent subagents when the host permits them, while recording incomplete or unavailable scopes instead of treating them as no findings. The canonical skill remains the source for Claude and Copilot adapters.

Dependencies: none.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves an existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Not applicable.

Checklist

  • I have run the black . command to format the code base.
  • I reviewed affected documentation and agent context, updated it where needed, or explained why no update was needed.
  • Public API changes are reflected in the API docs (python docs/scripts/check_api_docs.py), if applicable.
  • I have added tests that prove my fix is effective or that my feature works.
  • Dependencies have been updated, if applicable.

Validation

  • python /root/.codex/skills/.system/skill-creator/scripts/quick_validate.py .agents/skills/review-pr — passed.
  • black --check --diff --color ./ — passed; 1132 files unchanged.
  • python docs/scripts/check_api_docs.py — passed; 2257/2257 exports documented.
  • git diff --check origin/main...HEAD — passed.
  • The protocol was exercised against PR Use MJVBD V2 as the default Newton solver #645 with independent role passes, lead verification, and explicit fallback reporting.

@yuecideng yuecideng added enhancement New feature or request docs Improvements or additions to documentation agent Features related to agentic system labels Sep 23, 2026
@greptile-apps

greptile-apps Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the supplemental-role ambiguity has been resolved and no actionable regressions remain.

Summary

This PR replaces informal review perspectives with a coordinated expert-review protocol. It:

  • Defines stable IDs and responsibilities for core and supplemental reviewer roles.
  • Specifies bounded role selection, delegated task packets, result contracts, and lead verification.
  • Requires explicit fallback and incomplete-scope reporting.
  • Adds role-coverage reporting and clarifies how dedicated and embedded supplemental lenses are recorded.
  • Resolves the earlier ambiguity around reliability and verification by defining both as stable roles and documenting their consistent use.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Pin review target and build change model] --> B[Select relevant role IDs]
    B --> C{Subagents available and permitted?}
    C -->|Yes| D[Dispatch independent expert passes]
    C -->|No| E[Run separate lead passes as fallback]
    D --> F[Collect complete, partial, or unavailable results]
    E --> F
    F --> G[Lead verifies evidence and reachability]
    G --> H[Deduplicate and disposition candidates]
    H --> I[Check changed-file and role coverage]
    I --> J{Any selected scope unreviewed?}
    J -->|Yes| K[Report incomplete coverage or blocking findings]
    J -->|No| L[Publish verified findings and coverage tables]
Loading

Reviews (2) · Last reviewed commit: "fix(review): define supplemental reviewe..."

@greptile-apps

This comment has been minimized.

@yuecideng
yuecideng merged commit f7183ed into main Sep 23, 2026
8 checks passed
@yuecideng
yuecideng deleted the codex/review-expert-protocol-pr branch September 23, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Features related to agentic system docs Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant