Skip to content

Mark chat and small components for the component picker - #569

Merged
woksin merged 1 commit into
mainfrom
l163/478-marker-tranche
Nov 21, 2026
Merged

woksin merged 1 commit into
mainfrom
l163/478-marker-tranche

Conversation

@woksin

@woksin woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Changed

@woksin woksin added the patch label Nov 21, 2026
@woksin woksin self-assigned this Nov 21, 2026
@woksin

woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes

  • Markers go on each component's existing root element; no wrapper elements, and DOM structure, ids, classes and parts are unchanged. The pending-marker inventory drops from 27 to 14 and the ceiling is lowered to match.
  • Not marked in this batch: GlyphMenu (trigger plus portal, no single root) and ChatSidebarForObservableQueries (fragment that delegates).
  • ChatConversation and ChatMessageBubble got a behaviour-preserving refactor (extracted helpers). Code Health went from 8.44 to 8.81 and from 9.23 to 9.63. ChatConversation is still below 9.5 and will be tracked for further uplift.
  • One existing exact-markup expectation in the ChatTopicList specs now includes the marker.
  • Local: root yarn ci passed on this head; the package's 4,100 specs, lint, build and API-surface checks pass. Storybook story tests run in CI.
  • Presentation descriptors and the remaining pending components come in later batches.

@woksin
woksin merged commit 226870e into main Nov 21, 2026
44 of 45 checks passed
@woksin
woksin deleted the l163/478-marker-tranche branch November 21, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant