Skip to content

Code Health: raise all files to 9.5 #570

Open

Description

@woksin

Goal

Raise every source file in this repository to CodeScene Code Health 9.5 or higher. Each step is a behaviour-preserving refactor with specs behind it, one refactor per commit.

Files below 9.5

Files are added to this list when a change touches them but cannot bring them to 9.5 in the same change:

Acceptance criteria

  • Every listed file scores 9.5 or higher, with no behaviour change and its existing specs green.
  • Generated code is excluded.
  • Files are worked hotspots first.

Activity

  1. woksin commented on Nov 21, 2026

    @woksin
    ContributorAuthor

    Two more files to raise, touched by the #478 marker batch in #571 with one-line attribute additions only: Source/ObjectContentEditor/ObjectContentEditor.tsx (6.08) and Source/SchemaEditor/Tree/TreeSchemaEditor.tsx (9.05).

  2. self-assigned this
    on Nov 22, 2026
  3. woksin commented on Nov 22, 2026

    @woksin
    ContributorAuthor

    Released in v4.57.0 (#573): Source/Chat/ChatConversation.tsx and Source/SchemaEditor/Tree/TreeSchemaEditor.tsx raised to Code Health 10 through behaviour-preserving refactors with focused specs.

    Remaining: ObjectContentEditor (6.08).

  4. woksin commented on Nov 22, 2026

    @woksin
    ContributorAuthor

    Released in v4.58.0 (#574): Source/ObjectContentEditor/ObjectContentEditor.tsx raised from 6.08 to 10 by extracting private helpers in the same folder, with characterization specs added first. Rendered markup and the public signature are unchanged.

    The three files listed so far (ChatConversation, TreeSchemaEditor, ObjectContentEditor) now all score 10. The issue stays open for the repository-wide goal; the next step is a hotspot baseline to pick further files.

  5. woksin commented on Nov 22, 2026

    @woksin
    ContributorAuthor

    Released in v4.59.0 (#575): Common/NumberInput.tsx 6.44 → 9.66 and Canvas/shapes/Note/Note.tsx 6.67 → 9.68, behaviour preserved, with characterization specs added first. Two extracted helpers (renderNumberInput*) score 9.44 after the single pass.

    Baseline of the 111 largest source files; the lowest remaining:

    File Code Health
    PivotViewer/engine/store.ts 6.69
    PivotViewer/components/pivot/groups.ts 6.75
    PivotViewer/components/pivot/sprites.ts 6.77
    Canvas/shapes/Region/Region.tsx 7.46
    Common/ComboBox.tsx 7.76
    ConfigurationEditor/PropertyControl.tsx 7.87
    SchemaEditor/Tree/SchemaPropertyRow.tsx 7.93
    Toolbar/ToolbarFolder.tsx 8.00
    ConfigurationEditor/OrderedItemRow.tsx 8.11
    ConfigurationEditor/OrderedItemEditor.tsx 8.28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions