Skip to content

Raise conformance runner, DataTable row and query stories to Code Health 10 - #565

Merged
woksin merged 5 commits into
mainfrom
l163/506-uplift-b8
Nov 21, 2026
Merged

woksin merged 5 commits into
mainfrom
l163/506-uplift-b8

Conversation

@woksin

@woksin woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Changed

  • Restructured the conformance runner, the DataTable row and the query DataTable stories internally for maintainability, with no change to rendering, keyboard behavior or public API (part of Code Health: raise Components files to 9.5 #506)

@woksin woksin added the no-release Merging publishes no package, image, release, or deployment label Nov 21, 2026
@woksin woksin self-assigned this Nov 21, 2026
@woksin

woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes

  • Code Health went from 9.38 to 10 for Conformance/src/runConformance.tsx, 9.38 to 10 for Source/DataTables/DataTableRow.tsx, 9.04 to 10 for DataTableForQuery.stories.tsx and 9.38 to 10 for DataTableForObservableQuery.stories.tsx.
  • New specs: 11 DataTableRow specs pin rendering and keyboard activation behind the refactor.
  • Local gates on the PR head passed: the root yarn ci workspace gate, the Conformance and Components workspace CI and the Storybook preflight.
  • Review: one cross-provider round, including a security pass, passed with no findings.
  • Public API, story IDs and inventories are unchanged.

@woksin
woksin merged commit 99725bc into main Nov 21, 2026
43 of 44 checks passed
@woksin
woksin deleted the l163/506-uplift-b8 branch November 21, 2026 17:46
@woksin woksin mentioned this pull request Nov 21, 2026
25 of 29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Merging publishes no package, image, release, or deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant