Repository navigation
Description
Raise Code Health of the Components files below 9.5 without behavior or public API changes. Scores measured on main 5f29a4b (commits over 90 days). New files aim for 10; no file may decline.
-
Source/Dropdown/DropdownImplementation.tsx(4.89, 13) → 10 (Code Health: dropdown, date picker input and toolbar navigation (part of #506) #507) -
Source/Common/useToolbarKeyboardNavigation.ts(6.41, 11) → 10 (Code Health: dropdown, date picker input and toolbar navigation (part of #506) #507) -
Source/Common/DatePickerInputImplementation.tsx(6.62, 13) → 9.55 (Code Health: dropdown, date picker input and toolbar navigation (part of #506) #507) -
Source/DataTables/ColumnFilterMenu.tsx(7.36, 20) → 9.66 (Code Health: schema editor, type cell, column filter menu, chat sidebar and dialog (part of #506) #521) -
Source/Chat/ChatSidebar.tsx(7.57, 15) → 10 (Code Health: schema editor, type cell, column filter menu, chat sidebar and dialog (part of #506) #521) -
Source/SchemaEditor/SchemaEditor.tsx(7.61, 21) → 10 (Code Health: schema editor, type cell, column filter menu, chat sidebar and dialog (part of #506) #521) -
Source/Dialogs/DialogImplementation.tsx(7.65, 15) → 10 (Code Health: schema editor, type cell, column filter menu, chat sidebar and dialog (part of #506) #521) -
Source/CommandDialog/CommandStepperContent.tsx(7.67, 12) → 10 (Code Health: command stepper, provider, data table core, chips field and canvas (part of #506) #522) -
Source/SchemaEditor/TypeCell.tsx(7.88, 11) → 9.66 (Code Health: schema editor, type cell, column filter menu, chat sidebar and dialog (part of #506) #521) -
Source/Common/CratisComponentsProvider.tsx(8.65, 28) → 10 (Code Health: command stepper, provider, data table core, chips field and canvas (part of #506) #522) -
Source/DataTables/DataTableCore.tsx(8.69, 36) → 9.68 (Code Health: command stepper, provider, data table core, chips field and canvas (part of #506) #522) -
Source/CommandForm/fields/ChipsField.tsx(8.82, 15) → 9.44 in Code Health: command stepper, provider, data table core, chips field and canvas (part of #506) #522 → 10 (Code Health: chips, password, toaster, events view, chat topics, filter panel and pivot viewer (part of #506) #523) -
Source/Canvas/Canvas.tsx(8.86, 14) → 10 (Code Health: command stepper, provider, data table core, chips field and canvas (part of #506) #522) -
Source/PivotViewer/PivotViewer.tsx(8.93, 17) → 10 (Code Health: chips, password, toaster, events view, chat topics, filter panel and pivot viewer (part of #506) #523) -
Source/Notifications/Toaster.tsx(8.95, 14) → 9.52 (Code Health: chips, password, toaster, events view, chat topics, filter panel and pivot viewer (part of #506) #523) -
Source/CommandForm/fields/PasswordField.tsx(9.00, 13) → 9.68 (Code Health: chips, password, toaster, events view, chat topics, filter panel and pivot viewer (part of #506) #523) -
Source/TimeMachine/EventsView.tsx(9.07, 11) → 10 (Code Health: chips, password, toaster, events view, chat topics, filter panel and pivot viewer (part of #506) #523) -
Source/Chat/ChatTopicList.tsx(9.13, 13) → 9.66 (Code Health: chips, password, toaster, events view, chat topics, filter panel and pivot viewer (part of #506) #523) -
Source/Filter/FilterPanel.tsx(9.38, 39) → 9.68 (Code Health: chips, password, toaster, events view, chat topics, filter panel and pivot viewer (part of #506) #523)
Added by the Designsystemet adapter work
Files touched while adding Designsystemet support (#530, #531) that could not reach 9.5 in that change. Scores measured on main fd5e1d5.
-
Adapters/Mui/src/index.tsx(6.22 → 10 after the slot-module split, Split MUI and PrimeReact adapters into slot modules; fix tooltip snippet #555) -
Adapters/PrimeReact10/src/index.tsx(6.28 → 10 after the slot-module split, Split MUI and PrimeReact adapters into slot modules; fix tooltip snippet #555) -
scripts/generate-compat-manifest.mjs(6.42 → 10, Raise Code Health of the compatibility manifest generator and renderer matrix scope #561) -
Adapters/PrimeReact/src/index.tsx(6.50 → 10 after the slot-module split, Split MUI and PrimeReact adapters into slot modules; fix tooltip snippet #555) -
Conformance/src/runConformance.tsx(7.05) -
Conformance/src/internal/slotProfiles.tsx(8.54) -
Adapters/Designsystemet/src/choice.tsx(8.60) -
Adapters/Designsystemet/src/fields.tsx(8.97) -
Adapters/Designsystemet/src/paginator.tsx(8.84 -> 10 in Add Material UI paginator and dialog slots #553) -
Storybook/scripts/lib/renderer-matrix-scope.mjs(9.38 → 10, Raise Code Health of the compatibility manifest generator and renderer matrix scope #561)
Acceptance criteria
- Each listed file scores at least 9.5, or the reason it cannot without a public API change is recorded and moved to a next-major issue.
- No touched file declines; new files score 10.
- Characterization specs cover the behavior of each restructured component before it changes.
- Exported components, props and hooks keep their signatures; rendered output and interactions are unchanged.
- Lint, compile, specs and the Storybook build pass.
Status
State: In review — Batch 6: manifest generator and renderer matrix scope to 10; adapter index files already 10. Remaining: runConformance, slotProfiles, Designsystemet choice/fields.
Branch: l163/506-uplift-b6 (#555, #561)
Scope: Characterization specs then behavior-preserving refactors, worst files first, in batches.
Plan: Conformance first behind a whole-report characterization spec (check order, ids, statuses, messages), then verbatim moves into internal modules and complexity cuts (context object, checkSlot split into ordered stages, helper factories); adapter choice/button files get DOM characterization specs before their splits. Per-package ci plus renderer adapter matrix as the gate.
Delivered: Nothing yet.
Remaining: To be confirmed.
Follow-ups: None.
Activity
Merge pull request #507 from Cratis/components-506-code-health
woksin commentedon Nov 14, 2026
Unfinished work for this issue from a retired local worktree is preserved on branch
components-506-code-health-b2(head677e455323). No PR was opened; pick it up from that branch if it is still useful.woksin commentedon Nov 15, 2026
Unfinished work for this issue is on branch
l155/comp-codehealth(pushed, no PR yet): Code Health refactors and specifications for TypeCell, ColumnFilterMenu, ChatSidebar, DialogImplementation and SchemaEditor. The local worktree was removed during cleanup.woksin commentedon Nov 15, 2026
Add
Source/PivotViewer/usePivotStage.ts: Code Health 8.46 before, 8.48 after #515 (a scoped bug fix; the refactor to 9.5 was too large for that change).Merge pull request #521 from Cratis/train/components-506-batch2
Merge pull request #522 from Cratis/train/components-506-batch3
woksin commentedon Nov 16, 2026
Proactive Code Health uplift is paused by maintainer direction: files are raised only when planned work touches them.
Batches 1–3 shipped in #521 and #522. A fourth batch (ChipsField, PasswordField, Toaster, EventsView, ChatTopicList, FilterPanel and PivotViewer, all now at 9.5 or above) is finished and pushed to the branch
l135/comp-codehealth-b4without a pull request, so it can be picked up later if wanted.Merge pull request #523 from Cratis/l135/comp-codehealth-b4
woksin commentedon Nov 16, 2026
Batch 4 shipped in #523: ChipsField (10), PasswordField (9.68), Toaster (9.52), EventsView (10), ChatTopicList (9.66), FilterPanel (9.68) and PivotViewer (10), with no behavior or public API change.
Shipped so far for this issue: #507, #521, #522 and #523. The issue stays paused: proactive uplift is stopped by maintainer direction, and the remaining files are raised only when planned work touches them.
woksin commentedon Nov 18, 2026
Touched by #528 without decline, still below 9.5 (button slot renderers in the adapter entry files):
Adapters/Mui/src/index.tsx: 6.22Adapters/PrimeReact/src/index.tsx: 6.50Adapters/PrimeReact10/src/index.tsx: 6.28woksin commentedon Nov 19, 2026
Add
Adapters/Mui/src/index.tsx(Code Health 6.22, measured while adding the MUIcommon.tooltipslot for #541; the file was already large before that change).woksin commentedon Nov 21, 2026
Batches 6 and 7 are merged (#561, #562). Code Health now:
scripts/generate-compat-manifest.mjs6.42 → 10 (Raise Code Health of the compatibility manifest generator and renderer matrix scope #561)Storybook/scripts/lib/renderer-matrix-scope.mjs9.38 → 10 (Raise Code Health of the compatibility manifest generator and renderer matrix scope #561)Adapters/Mui/src/index.tsx,Adapters/PrimeReact/src/index.tsx,Adapters/PrimeReact10/src/index.tsxalready at 10 after the slot-module split (Split MUI and PrimeReact adapters into slot modules; fix tooltip snippet #555)Conformance/src/internal/slotProfiles.tsx8.54 → 10 (Raise Code Health of the conformance runner and Designsystemet choice and field adapters #562)Adapters/Designsystemet/src/choice.tsx8.60 → 10 (Raise Code Health of the conformance runner and Designsystemet choice and field adapters #562)Adapters/Designsystemet/src/fields.tsx8.97 → 10 (Raise Code Health of the conformance runner and Designsystemet choice and field adapters #562)Conformance/src/runConformance.tsx7.04 → 9.38 (Raise Code Health of the conformance runner and Designsystemet choice and field adapters #562)Remaining:
Conformance/src/runConformance.tsxis the only listed file still below 9.5; its remaining finding is the runner's aggregate complexity.woksin commentedon Nov 21, 2026
The DataTable mobile card layout (#563) touched three files that were already below 9.5 on main. Their scores did not change:
Source/DataTables/DataTableRow.tsx: 9.38Source/DataTables/DataTableForQuery.stories.tsx: 9.04Source/DataTables/DataTableForObservableQuery.stories.tsx: 9.38All three are held back by branch-heavy methods. They join
Conformance/src/runConformance.tsxon the remaining uplift list.woksin commentedon Nov 21, 2026
Batch 8 is merged (#565), and with it every file on this list is at 9.5 or higher:
Conformance/src/runConformance.tsx9.38 → 10 (Raise conformance runner, DataTable row and query stories to Code Health 10 #565; it was 7.05 → 9.38 in Raise Code Health of the conformance runner and Designsystemet choice and field adapters #562)Source/DataTables/DataTableRow.tsx9.38 → 10 (Raise conformance runner, DataTable row and query stories to Code Health 10 #565)Source/DataTables/DataTableForQuery.stories.tsx9.04 → 10 (Raise conformance runner, DataTable row and query stories to Code Health 10 #565)Source/DataTables/DataTableForObservableQuery.stories.tsx9.38 → 10 (Raise conformance runner, DataTable row and query stories to Code Health 10 #565)The unticked items above are also delivered:
Conformance/src/internal/slotProfiles.tsx8.54 → 10,Adapters/Designsystemet/src/choice.tsx8.60 → 10 andAdapters/Designsystemet/src/fields.tsx8.97 → 10, all in #562. No public API, rendered output or story changes; characterization specs cover each restructured file. Closing as complete.