Skip to content

Add opt-in mobile card layout to DataTables - #563

Merged
woksin merged 3 commits into
mainfrom
l163/556-datatable-cards
Nov 21, 2026
Merged

woksin merged 3 commits into
mainfrom
l163/556-datatable-cards

Conversation

@woksin

@woksin woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Added

@woksin woksin added the minor label Nov 21, 2026
@woksin woksin self-assigned this Nov 21, 2026
@woksin woksin added the minor label Nov 21, 2026
@woksin

woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes

  • Local gates on the PR head: the root yarn ci workspace gate passed, including the TypeScript 6 and 7 packed-consumer matrix. The focused DataTables specs, the Chromium viewport suite (7 tests) and the Storybook preflight also passed.
  • Review: three cross-provider rounds. Round 1 found two blocking issues: the select-all indeterminate state was lost when the layout switched, and a browser focus spec could not pass with its fixture. Round 2 found that the mobile story passed its columns through a Fragment. All are fixed, and round 3 passed with no findings. A security pass found no trust-boundary changes.
  • CSS budgets: the aggregate raw size and declaration-block ceilings were raised to the measured values. The SchemaEditor per-area gzip budget went from 9216 to 10240 bytes (measured 9298, was 9154). Its growth comes only from the DataTable CSS that area already bundles. Gzip ceilings for the other areas are unchanged.
  • Code Health: new files are at 9.68 or higher. DataTableCore.tsx stays at 9.68. DataTableRow.tsx and the two query story files were already below 9.5 on main and did not decline; they are tracked in the Code Health uplift (Code Health: raise Components files to 9.5 #506).
  • Not verified locally: a manual phone smoke test and axe, forced-colors or reduced-motion visual checks of the card layout.

@woksin
woksin merged commit 889d12c into main Nov 21, 2026
44 of 45 checks passed
@woksin
woksin deleted the l163/556-datatable-cards branch November 21, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant