Skip to content

Raise Code Health of the conformance runner and Designsystemet choice and field adapters - #562

Merged
woksin merged 4 commits into
mainfrom
l163/506-uplift-b7
Nov 21, 2026
Merged

woksin merged 4 commits into
mainfrom
l163/506-uplift-b7

Conversation

@woksin

@woksin woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Simplifies the conformance runner, its slot profiles and the Designsystemet choice and field adapters without changing their behavior, and adds specs covering them (part of #506).

Changed

  • The conformance runner and slot profiles, and the Designsystemet choice and field adapters, are split into smaller functions with added specs; rendering and public exports are unchanged (part of Code Health: raise Components files to 9.5 #506)

@woksin woksin added the no-release Merging publishes no package, image, release, or deployment label Nov 21, 2026
@woksin woksin self-assigned this Nov 21, 2026
@woksin

woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes

  • Code Health: Conformance/src/runConformance.tsx 7.04 -> 9.38 (still below 9.5: remaining aggregate complexity of the runner; one refactor pass, stays on Code Health: raise Components files to 9.5 #506); Conformance/src/internal/slotProfiles.tsx 8.54 -> 10; Adapters/Designsystemet/src/choice.tsx 8.60 -> 10; Adapters/Designsystemet/src/fields.tsx 8.97 -> 10. One commit per file, each with specs.
  • Local gate: root yarn ci at ca59c15 passed (including the compatibility-manifest check and the TypeScript 6/7 packed-consumer matrix); yarn verify-renderer-adapters passed.
  • Review: full cross-provider review with security lens passed with no findings.

@woksin
woksin merged commit e405578 into main Nov 21, 2026
43 of 44 checks passed
@woksin
woksin deleted the l163/506-uplift-b7 branch November 21, 2026 14:37
@woksin woksin mentioned this pull request Nov 21, 2026
25 of 29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Merging publishes no package, image, release, or deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant