Repository navigation
Fix Carrot theme severity indicator contrast - #443
Open
somethingwithproof wants to merge 1 commit into
Open
somethingwithproof wants to merge 1 commit into
somethingwithproof wants to merge 1 commit into
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
TheWitness
force-pushed
the
fix/carrot-theme-status-contrast
branch
from
October 26, 2026 14:20
62c3d60 to
96234bc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Give Carrot's details severity indicator a contrasting white backing scoped to Intropage's details overlay. Use darker warning/unknown dots and row markers. This works with existing coral titlebars and darker host palettes without restyling other Cacti pages.
Related Issue
Fixes #442. Stacked on #441 to reuse the browser test harness and coverage gate.
Motivation and Context
All four original details dots were below 3:1 contrast against coral: green 1.93:1, red 2.12:1, warning 1.01:1, and grey 1.03:1. Warning and unknown markers also fell below 3:1 against light rows. Header severity backgrounds remain unchanged.
How Has This Been Tested?
Eight Chromium browser tests passed across Cacti and Carrot, including all four severity colors on white, odd, and even rows. The seeded E2E fixture displays measurements and opens and closes the real jQuery UI details dialog. Original Carrot CSS fails the regression assertions. Changed CSS coverage is 9/9 lines (100%), not whole-plugin coverage. Manifest, workflow lint, and whitespace checks passed. The workflow runs browser coverage for stacked theme PRs as well.
Screenshots
README and validation docs contain the same reproducible screenshots with synthetic devices, ping times, poller totals, and warning/error messages.
Types of changes
Checklist