Repository navigation
Fix Dark theme red row marker contrast - #445
Open
somethingwithproof wants to merge 1 commit into
Open
somethingwithproof wants to merge 1 commit into
somethingwithproof wants to merge 1 commit into
Conversation
somethingwithproof
changed the title
somethingwithproof
marked this pull request as ready for review
October 26, 2026 03:56
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
TheWitness
force-pushed
the
fix/dark-theme-status-contrast
branch
from
October 26, 2026 14:20
f89fe54 to
8307c5b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark's red row marker has only 2.49:1 contrast against odd rows. Use a brighter red for row markers while preserving the panel header palette and existing details dots.
Fixes #444.
Extends the shared browser fixtures from #443 and targets that branch in the native theme PR stack. Includes populated synthetic monitoring screenshots in the README and validation documentation.
Validation: all 12 Chromium tests pass, including all four severity colors on odd/even/page surfaces and opening/closing the seeded details dialog. Changed CSS coverage is 100% (2/2 executable added lines). Contrast checks composite translucent colors and include linear-gradient stops. These fixtures exercise the real stylesheets and jQuery UI, not a live installation.