Repository navigation
Fix severity indicator contrast in the Cacti theme - #441
Merged
Merged
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
3 of 5 tasks
TheWitness
approved these changes
Oct 26, 2026
TheWitness
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use brighter green and red severity dots on dark details titlebars, and darker warning and unknown markers on light table rows. Header background colors remain the same. All four severity indicators meet 3:1 contrast on their respective surfaces.
Related Issue
Fixes #440.
Motivation and Context
The old green and red dots measured 1.83:1 and 1.67:1 against the details titlebar. Warning and unknown markers also fell below 3:1 on light rows. Separate colors for titlebar dots and row markers keep status visible on each background.
How Has This Been Tested?
Four Chromium browser tests passed, covering all four severity colors on white, odd, and even rows. A seeded E2E fixture displays device measurements and opens and closes the real jQuery UI details dialog. Regression assertions fail against the original stylesheet. Changed CSS coverage is 6/6 lines (100%), enforced by the browser job using Cacti's pinned, existing Playwright tooling and coverage reporter. This measures changed CSS lines, not whole-plugin coverage. Manifest, workflow lint, and whitespace checks passed.
README and validation docs include screenshots generated from synthetic monitoring data, with device names, ping times, poller totals, and actual warning/error text.
Screenshots
Types of changes
Checklist