Repository navigation
fix(css): repair invalid rules and remove unused ones - #437
Merged
Merged
Conversation
The // comments before the two @media blocks made the browser drop both, so the responsive panel widths never applied. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
TheWitness
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the
//comments before the two@mediablocks incss/common.csswith/* */comments so the blocks are parsed. Also removesscroll: auto(not a CSS property), the shadowed second.rpadrule, and rules for classes and ids that nothing in the PHP or JavaScript emits (.header_link,.db_href,.db_href_active,.href_disabled,.texalirig,.red,.panel-link,#detail_in,#block,#generated).Related Issue
Fixes #436
Motivation and Context
The responsive panel widths have never applied. At a 400 px viewport the panels stay 340, 460 and 580 px wide.
How Has This Been Tested?
Stylelint 17.16.0 with
stylelint-config-recommendedandno-duplicate-selectors: 4 problems before, 0 after.Computed styles of 44 probe elements, in and outside the plugin wrappers, were recorded in headless Chrome for common.css alone and with each of the 12 themes at 1200, 600 and 400 px, before and after. At 1200 px nothing differs. The only differences are the panel width, min-width and overflow at 600 and 400 px, which now follow the media rules. The removed rules had no effect on any probe.
The 600 px rules were not checked on a live dashboard, only on probe elements.
Types of changes