Repository navigation
fix(css): scope generic helper classes to the plugin wrappers - #439
Open
somethingwithproof wants to merge 2 commits into
Open
somethingwithproof wants to merge 2 commits into
somethingwithproof wants to merge 2 commits into
Conversation
.fa, .block, .float_*, .rpad, .w60 and .txt_* were global, so the plugin's stylesheet restyled the same classes on every other Cacti page. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/css-scope-generic-classes
branch
from
October 26, 2026 21:51
bdf4fb8 to
1a9de10
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin stylesheet loads on every Cacti page, so generic helper classes also restyled content outside Intropage. Scope font sizes, padding, floats, widths, and display helpers to #intropage_main and #overlay.
Fixes #438. The prerequisite #437 has merged; this branch now targets develop with only its own scoping change and browser regression tests.
Six Chromium cases pass, including helper behavior inside both wrappers and unchanged computed styles outside them for Cacti and Midwinter. The existing populated dashboard/details tests also pass. Changed executable CSS line coverage is 100%: 18/18 lines in common.css and 6/6 in midwinter.css, measured against develop.
The graph page's Add to Dashboard icon is outside the wrappers and no longer receives the plugin's 3px helper padding.