Repository navigation
Build the Wait debug line only at DEBUG, and skip objects the state lacks - #203
Open
yichao-liang wants to merge 1 commit into
Open
yichao-liang wants to merge 1 commit into
yichao-liang wants to merge 1 commit into
Conversation
…acks option_policy_to_policy built _format_wait_target_debug's string on Wait step 1 and every 25 steps whenever an abstract function was wired, even with DEBUG logging off, and the formatter read every target object's features from the state. Process planning injects ground-truth helper objects (the Fan grid's loc_* cells) only into the planning task and re-derives them inside its abstract function, so the executed state lacks them: the Fan process-planning oracle on the historical arena crashed at its first Wait with KeyError: loc_0.7900_1.6840:loc. The wrapper now builds the line only when the root logger is enabled for DEBUG, and the formatter lists a target object the state does not contain as "not in state" without reading its features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
option_policy_to_policybuilt_format_wait_target_debug's string on Wait step 1 and every 25 steps whenever an abstract function was wired, even with DEBUG logging off.The formatter read every target object's features from the state.
Process planning injects ground-truth helper objects (the Fan grid's
loc_*cells) only into the planning task and re-derives them inside its abstract function, so the executed state lacks them.The Fan process-planning oracle on the historical arena (
HISTORICAL_ARENA_FLAGS) therefore crashed at its first Wait withKeyError: loc_0.7900_1.6840:locfromState.get.The wrapper now builds the line only when the root logger is enabled for DEBUG.
The formatter lists a target object the state does not contain as
not in stateand skips its features, so a debug message can no longer end an episode.Test plan
tests/test_wait_option_backstop.pyrun a Wait whose target atom names an object absent from the state.With DEBUG on, the debug line reports the object as
not in state; below DEBUG, the line is never built.On master the first fails with the same
KeyErrorand the second with the stub'sAssertionError.--timeout 60).This branch solves the task: SwitchOn, four Waits that end on their target atoms, SwitchOff.
Planning alone takes 58-67 s on the cluster's nodes, so at 60 s it timed out on two of three nodes (once on master, in skeleton search; once on this branch, in refinement).
--timeout 400, so that planning always finishes.Master finds the same 6-step plan and crashes at the first Wait with the
KeyError.This branch solves the task in all three runs, one of them with
--debug, where all 7 Wait debug lines list the twoloc_*cells asnot in state.🤖 Generated with Claude Code